Skip to content

Add dump reporting for https://github.com/dotnet/roslyn/issues/76225 #78354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2025
Merged

Add dump reporting for https://github.com/dotnet/roslyn/issues/76225 #78354

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9363b87
Add dump reporting for https://github.com/dotnet/roslyn/issues/76225
ToddGrun Apr 28, 2025
323b353
Update comment
ToddGrun Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/Workspaces/Core/Portable/Diagnostics/DiagnosticData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
using System.Runtime.Serialization;
using System.Threading;
using System.Threading.Tasks;
using Microsoft.CodeAnalysis.ErrorReporting;
using Microsoft.CodeAnalysis.Host;
using Microsoft.CodeAnalysis.PooledObjects;
using Microsoft.CodeAnalysis.Shared.Extensions;
Expand Down Expand Up @@ -180,7 +181,17 @@ void GetLocationInfo(out FileLinePositionSpan originalLineInfo, out FileLinePosi
}
else
{
originalLineInfo = location.GetLineSpan();
try
{
originalLineInfo = location.GetLineSpan();
}
catch (Exception e) when (FatalError.ReportWithDumpAndCatch(e, ErrorSeverity.Critical))
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is tehre no REportWithDumpAndPropagate?

Copy link
Member

@CyrusNajmabadi CyrusNajmabadi Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guess there isn't!

Copy link
Member

@CyrusNajmabadi CyrusNajmabadi Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would explicitly add a comment stating this is for #74728

{
// Help track down https://github.com/dotnet/roslyn/issues/76225 which appears to be an
// issue caused by https://github.com/dotnet/roslyn/pull/74728
throw;
}

mappedLineInfo = location.GetMappedLineSpan();
}
}
Expand Down
Loading