From a60bba1dfe65e4e230bdb5a80c98d70eaed49fcc Mon Sep 17 00:00:00 2001 From: tmat Date: Wed, 30 Apr 2025 12:58:12 -0700 Subject: [PATCH 1/2] Implement workaround for missing ValueTuple in remote debugger --- src/Dependencies/Contracts/Range.cs | 3 +++ .../Microsoft.CodeAnalysis.FunctionResolver.csproj | 7 +++++++ 2 files changed, 10 insertions(+) diff --git a/src/Dependencies/Contracts/Range.cs b/src/Dependencies/Contracts/Range.cs index 2792c21056613..0ee4eba72c798 100644 --- a/src/Dependencies/Contracts/Range.cs +++ b/src/Dependencies/Contracts/Range.cs @@ -72,6 +72,8 @@ public override string ToString() /// Create a Range object starting from first element to the end. public static Range All => new Range(Index.Start, Index.End); +#if !NO_VALUE_TUPLE // workaround for https://github.com/dotnet/roslyn/issues/78392 + /// Calculate the start offset and length of range object using a collection length. /// The length of the collection that the range will be used with. length has to be a positive value. /// @@ -103,6 +105,7 @@ public override string ToString() return (start, end - start); } +#endif } } #endif diff --git a/src/ExpressionEvaluator/Core/Source/FunctionResolver/Microsoft.CodeAnalysis.FunctionResolver.csproj b/src/ExpressionEvaluator/Core/Source/FunctionResolver/Microsoft.CodeAnalysis.FunctionResolver.csproj index 5744d70120de4..f29448f231aa3 100644 --- a/src/ExpressionEvaluator/Core/Source/FunctionResolver/Microsoft.CodeAnalysis.FunctionResolver.csproj +++ b/src/ExpressionEvaluator/Core/Source/FunctionResolver/Microsoft.CodeAnalysis.FunctionResolver.csproj @@ -8,6 +8,13 @@ true netstandard2.0 true + + + $(DefineConstants);NO_VALUE_TUPLE From c32ffdd4ff1ea4a0c07317c17f42fca4f3f0f752 Mon Sep 17 00:00:00 2001 From: tmat Date: Wed, 30 Apr 2025 13:04:53 -0700 Subject: [PATCH 2/2] Set symbol in resolve provider as well --- .../Portable/Microsoft.CodeAnalysis.ResultProvider.csproj | 7 +++++++ .../Microsoft.CodeAnalysis.ResultProvider.Utilities.csproj | 7 +++++++ 2 files changed, 14 insertions(+) diff --git a/src/ExpressionEvaluator/Core/Source/ResultProvider/Portable/Microsoft.CodeAnalysis.ResultProvider.csproj b/src/ExpressionEvaluator/Core/Source/ResultProvider/Portable/Microsoft.CodeAnalysis.ResultProvider.csproj index c28f388bd2ddc..ae069519af0b7 100644 --- a/src/ExpressionEvaluator/Core/Source/ResultProvider/Portable/Microsoft.CodeAnalysis.ResultProvider.csproj +++ b/src/ExpressionEvaluator/Core/Source/ResultProvider/Portable/Microsoft.CodeAnalysis.ResultProvider.csproj @@ -8,6 +8,13 @@ netstandard2.0 full true + + + $(DefineConstants);NO_VALUE_TUPLE diff --git a/src/ExpressionEvaluator/Core/Test/ResultProvider/Microsoft.CodeAnalysis.ResultProvider.Utilities.csproj b/src/ExpressionEvaluator/Core/Test/ResultProvider/Microsoft.CodeAnalysis.ResultProvider.Utilities.csproj index a62c0965c6d4a..2922ec2696f10 100644 --- a/src/ExpressionEvaluator/Core/Test/ResultProvider/Microsoft.CodeAnalysis.ResultProvider.Utilities.csproj +++ b/src/ExpressionEvaluator/Core/Test/ResultProvider/Microsoft.CodeAnalysis.ResultProvider.Utilities.csproj @@ -10,6 +10,13 @@ false true + + $(DefineConstants);NO_VALUE_TUPLE + $(NoWarn);CA1825