Ensure hover markdown for supported platforms uses non-breaking spaces for indentation #78405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for indentation
ghost
added
Area-IDE
untriaged
dibarbet
commented
May 1, 2025
| foreach (var project in projects) | ||
| { | ||
| var text = string.Format(FeaturesResources._0_1, project.Name, Supported(!InvalidProjects.Contains(project.Id))); | ||
| builder.AddSpace(" "); |
Member
Author
There was a problem hiding this comment.
moved the indentation from the resource string to here, so it gets properly tagged as spacing.
CyrusNajmabadi
approved these changes
May 2, 2025
Member
|
Probably my bad. Thanks! |
JoeRobich
approved these changes
May 2, 2025
Member
Author
|
/azp run roslyn-CI |
Member
Author
|
/azp run roslyn-integration-CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run roslyn-integration-CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves dotnet/vscode-csharp#8204
Supported platform information uses 4 spaces in its resource string
{0} - {1}for indentation in tool tips. However, 4 spaces at the beginning of the line in markdown indicates a code block, breaking the rendering of the supported platform info in LSP (thanks to @JoeRobich for spotting that!)Since the 4 spaces are intended to be structural indentation, we need to use non breaking spaces (
 ) in markdown. We already handle that generally when we see aTextTags.Spacekind. However in this case the 4 spaces were combined with the rest of the string and therefore tagged asTextinstead ofSpaceThe fix is to separate out the structural spacing from the rest of the string, and tag it as such. This lets our existing handling of spaces convert to non breaking spaces when it needs to.