Extensions: use specific tracking issues for different areas (second pass) #78971
Conversation
📝 LDM already made a decision on this (answer: no). I am still tracking an open issue in the spec to revisit the question, so I don't think it's useful to keep a follow-up link here Refers to: src/Compilers/CSharp/Test/Emit3/Semantics/ExtensionTests.cs:23106 in 569f8df. [](commit_id = 569f8df, deletion_comment = True) |
|
|
||
| wasError = (Method is not null && method is null) || (SetMethod is not null && setMethod is null); | ||
|
|
||
| // Tracked by https://github.com/dotnet/roslyn/issues/76130 : Test with indexers (ie. "method") and in compound assignment (ie. "setMethod") |
There was a problem hiding this comment.
📝 I added a note to indexers follow-up issue. @AlekseyTs, I assume you're already covering this in your current ref analysis work for operators
jcouv
force-pushed
the
extensions-issues2
branch
from
b473bc7 to
6330045
Compare
|
|
||
| wasError = (Method is not null && method is null) || (SetMethod is not null && setMethod is null); | ||
|
|
||
| // Tracked by https://github.com/dotnet/roslyn/issues/76130 : Test with indexers (ie. "method") and in compound assignment (ie. "setMethod") |
There was a problem hiding this comment.
Yes, the follow-up note was moved to ...
The issue looks indexer specific, but the mentioned scenario is not.
There was a problem hiding this comment.
For the operator scenario, I left a comment to you to check that you're tracking it as part of operators: #78971 (comment)
There was a problem hiding this comment.
For the operator scenario ...
I do not think this comment is about an operator scenario, but about a property scenario.
|
Done with review pass (commit 14) |
|
Given this is a comment-only change (ie. no code change), I'm going ahead merging with single review. |
Fix more Update versions Fix more In progress Flip Fix Fix remove wrapper Fix Fix in progress Fix DeclarationKind layering fix One building In progress Breaking out refactoring helpers into core api vs service VB side In progress Move type workaround Update src/Workspaces/SharedUtilitiesAndExtensions/Compiler/CSharp/CSharpCompilerExtensions.projitems Fix SubText ctor parameter verification. (dotnet#78989) * Fix SubText ctor parameter verification. This ctor currently throws given a zero length span at the end (and only the end) of the subtext. This evidently became far more prevalent with this (fairly) recent change to optimize newline information in our sourcetext classes. (dotnet#74728) It doesn't make to allow zero length spans at all locations but at the end of the subtext, so the fix is just to allow construction in that case too. Big props to Manish Vasani for providing a very actionable repro for this. Fixes dotnet#78985. Note there is a potentially related issue outlined in dotnet#76225 that looks attributable to the PR above too. It possible that this addresses that issue too, but I'm not completely convinced. Extensions: bind unconditionally of LangVer (dotnet#78947) Extensions: use specific tracking issues for different areas (second pass) (dotnet#78971) Fix nullable analysis involving extensions and collection expressions (dotnet#78926) Update src/Workspaces/SharedUtilitiesAndExtensions/Compiler/CSharp/CSharpCompilerExtensions.projitems in progrss Update src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/CompilerExtensions.projitems Update src/Workspaces/SharedUtilitiesAndExtensions/Compiler/VisualBasic/VisualBasicCompilerExtensions.projitems extensions Fix RootNamespace Fixes Fixes IN progress in progress
3 participants
Follow-up on #78834
This leaves 37 uncategorized follow-up comments (25 in code, 12 in test), down from 95.
Relates to test plan #76130