Skip to content

Propagate params to lambdas and local functions #79880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Sep 18, 2025
Merged

Propagate params to lambdas and local functions #79880

merged 14 commits into from
Sep 18, 2025

Conversation

@jjonescz
Copy link
Member

@jjonescz jjonescz commented Aug 12, 2025

Fixes #79752.

@jjonescz jjonescz marked this pull request as ready for review August 13, 2025 12:47
@jjonescz jjonescz requested a review from a team as a code owner August 13, 2025 12:47
@AlekseyTs
Copy link
Contributor

AlekseyTs commented Aug 14, 2025 •
edited
Loading

Does VB have the same issue with lambdas? At the very least we should add tests if the scenario is relevant for VB, I think. #Closed

@jjonescz
Copy link
Member Author

jjonescz commented Aug 14, 2025 •
edited
Loading

VB doesn't support params in lambdas. And VB doesn't have local functions. So I don't think there are any relevant tests I can add.

@333fred
Copy link
Member

333fred commented Aug 14, 2025

I'd like more understanding of the scenario before proceeding with implementation changes.

@KubaZ2 KubaZ2 mentioned this pull request Aug 15, 2025
Closed
@AlekseyTs
Copy link
Contributor

AlekseyTs commented Aug 21, 2025 •
edited
Loading

Are we testing lambdas and local functions inside new extension methods? They undergo a special rewrite. #Closed

jcouv
jcouv reviewed Aug 28, 2025
View reviewed changes
@jcouv jcouv mentioned this pull request Aug 28, 2025
Merged
jcouv
jcouv reviewed Aug 28, 2025
View reviewed changes
@jcouv jcouv self-assigned this Aug 28, 2025
@jjonescz jjonescz requested a review from a team September 3, 2025 08:47
jcouv
jcouv approved these changes Sep 8, 2025
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (commit 8)

@jjonescz jjonescz requested review from a team and AlekseyTs September 8, 2025 09:18
@AlekseyTs
Copy link
Contributor

AlekseyTs commented Sep 11, 2025 •
edited
Loading

Done with review pass (commit 12) #Closed

AlekseyTs
AlekseyTs reviewed Sep 11, 2025
View reviewed changes
AlekseyTs
AlekseyTs reviewed Sep 11, 2025
View reviewed changes
@AlekseyTs
Copy link
Contributor

AlekseyTs commented Sep 11, 2025 •
edited
Loading

Done with review pass (commit 13) #Closed

@AlekseyTs
Copy link
Contributor

AlekseyTs commented Sep 11, 2025 •
edited
Loading

Done with review pass (commit 14) #Closed

@AlekseyTs
Copy link
Contributor

AlekseyTs commented Sep 11, 2025 •
edited
Loading

Overall LGTM, but I'll wait for the breaking change approval before signing off. #Closed

@jjonescz jjonescz requested a review from AlekseyTs September 17, 2025 11:56
@jjonescz
Copy link
Member Author

jjonescz commented Sep 18, 2025

@AlekseyTs please take another look, the break was approved over email

AlekseyTs
AlekseyTs approved these changes Sep 18, 2025
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 14)

@jjonescz jjonescz merged commit 0b2145c into dotnet:main Sep 18, 2025
24 checks passed
@jjonescz jjonescz deleted the LambdaParamsAttribute branch September 18, 2025 12:53
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Sep 18, 2025
333fred added a commit that referenced this pull request Sep 18, 2025
@333fred
Merge remote-tracking branch 'upstream/main' into copilot/fix-77001
84dbe2c 
* upstream/main: (206 commits)
  Remove bogus xlf tag (#80357)
  Fix missing type argument checks
  Add tests
  Use dotnet run file for generating compiler code (#80248)
  Only restore based on assets file changes if the actual content changed (#80341)
  make expressionbody analyzer use semanticspananalysis (#80339)
  [EnC] Use ignoreAssemblyKey: false to resolve symbol keys (#80342)
  Properly populate ExportedType metadata table in presence of extension block. (#80311)
  Propagate `params` to lambdas and local functions (#79880)
  Change 17.15 to VS 2026 preview. (#80325)
  Improve virtualproject support for older .NET SDKs (#80324)
  Update dependencies from https://github.com/dotnet/dotnet build 283666 (#80344)
  Update dependencies from https://github.com/dotnet/arcade build 20250917.6 (#80343)
  Simplifying
  Fix tests
  Fix tests
  Fix introduce variable placement in top level statements
  move to immutable types in signature help
  move to immutable types in signature help
  Fix check
  ...
333fred added a commit to 333fred/roslyn that referenced this pull request Sep 18, 2025
@333fred
Merge remote-tracking branch 'upstream/main' into test-runtime-async
e13af0f 
* upstream/main: (31 commits)
  Remove bogus xlf tag (dotnet#80357)
  Fix missing type argument checks
  Add tests
  Use dotnet run file for generating compiler code (dotnet#80248)
  Only restore based on assets file changes if the actual content changed (dotnet#80341)
  make expressionbody analyzer use semanticspananalysis (dotnet#80339)
  [EnC] Use ignoreAssemblyKey: false to resolve symbol keys (dotnet#80342)
  Properly populate ExportedType metadata table in presence of extension block. (dotnet#80311)
  Propagate `params` to lambdas and local functions (dotnet#79880)
  Change 17.15 to VS 2026 preview. (dotnet#80325)
  Improve virtualproject support for older .NET SDKs (dotnet#80324)
  Update dependencies from https://github.com/dotnet/dotnet build 283666 (dotnet#80344)
  Update dependencies from https://github.com/dotnet/arcade build 20250917.6 (dotnet#80343)
  Simplifying
  Fix tests
  Fix tests
  Fix introduce variable placement in top level statements
  move to immutable types in signature help
  move to immutable types in signature help
  Fix check
  ...
@dotnet-bot dotnet-bot mentioned this pull request Sep 20, 2025
Closed
@akhera99 akhera99 modified the milestones: Next, 18.0 P1, 18.0 P2 Sep 22, 2025
This was referenced Sep 25, 2025
Closed
Closed
This was referenced Oct 27, 2025
Open
Closed
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlekseyTs AlekseyTs AlekseyTs approved these changes

@jcouv jcouv jcouv approved these changes

Assignees

@jcouv jcouv

Labels

Area-Compilers breaking-change https://github.com/dotnet/sdk/blob/main/documentation/project-docs/breaking-change-guidelines.md

Projects

None yet

Milestone

18.0 P2

Development

Successfully merging this pull request may close these issues.

ParamArrayAttribute and ParamCollectionAttribute missing for compiler generated symbols

5 participants

@jjonescz @AlekseyTs @333fred @jcouv @akhera99