Block manual application of MethodImplAttribute.Async to methods #80031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@jcouv @RikkiGibson for review |
jcouv
reviewed
Aug 25, 2025
src/Compilers/Core/Portable/Symbols/Attributes/CommonAttributeData.cs
Outdated
Show resolved
Hide resolved
jcouv
reviewed
Aug 25, 2025
jcouv
reviewed
Aug 25, 2025
Member
jcouv
left a comment
jcouv
left a comment
There was a problem hiding this comment.
Done with review pass (commit 1)
jcouv
reviewed
Aug 25, 2025
| // Error if [MethodImpl(MethodImplOptions.Async)] is used directly on a method | ||
| // We give an exception to the AsyncHelpers special type, as it manually implements the pattern as part of the | ||
| // runtime's async support | ||
| if ((InternalSpecialType)appliedToSymbol.ExtendedSpecialType != InternalSpecialType.System_Runtime_CompilerServices_AsyncHelpers) |
Member
There was a problem hiding this comment.
aside, and not part of your PR. but using a cast like this to go from a struct wrapper to an enum was absolutely not clear to me :D
CyrusNajmabadi
approved these changes
Aug 26, 2025
Member
CyrusNajmabadi
left a comment
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
Signing off as my questions are not blocking and the code seems clear and in line with corresponding surrounding code.
jcouv
reviewed
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to test plan #75960