Update VSInternalContinueCharacter* serialization #80085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exception counts during the RazorEditingTEsts.CompletionInLSP test is off the chart due to JS completion utilizing VSInternalContinueCharacter classes. These classes were being improperly serialized. The vslanguageserverclient part of this change went in via https://devdiv.visualstudio.com/DevDiv/_git/VSLanguageServerClient/pullrequest/665374 and has made it's way to the latest Int.Main. This PR simply does the same thing as the vslnaguageserverclient PR. Going to do a speedometer run on this and verify that the exception numbers come down significantly and will post those results when available.
CyrusNajmabadi
approved these changes
Aug 29, 2025
kayle
approved these changes
Aug 29, 2025
olegtk
approved these changes
Aug 29, 2025
This was referenced Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exception counts during the RazorEditingTEsts.CompletionInLSP test is off the chart due to JS completion utilizing VSInternalContinueCharacter classes. These classes were being improperly serialized. The vslanguageserverclient part of this change went in via https://devdiv.visualstudio.com/DevDiv/_git/VSLanguageServerClient/pullrequest/665374 and has made it's way to the latest Int.Main.
This PR simply does the same thing as the vslnaguageserverclient PR.
Test insertion: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/666067