Ensure that top-level statements entry point emits MethodImplAttributes.Async #80314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es.Async This was missing for TLS symbols. Fixes dotnet#80313.
Member
Author
|
@jcouv @RikkiGibson for review. Given the nature of the fix here, I'm thinking we don't need to modify every single test in this file to add runtime compilation, but if you think that would be good to add, I can open a follow-up issue to do that. |
RikkiGibson
reviewed
Sep 16, 2025
RikkiGibson
approved these changes
Sep 16, 2025
Member
|
I think having tests for various return types for the entry point method, might be worthwhile, but super broad coverage doesn't seem necessary. |
jcouv
reviewed
Sep 17, 2025
jcouv
approved these changes
Sep 17, 2025
Member
jcouv
left a comment
jcouv
left a comment
There was a problem hiding this comment.
LGTM Thanks (commit 1) modulo naming issue
This was referenced Sep 19, 2025
This was referenced Sep 25, 2025
This was referenced Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missing for TLS symbols. Fixes #80313.