Skip to content

Conversation

@333fred
Copy link
Member

@333fred 333fred commented Sep 18, 2025

This was causing the failures on Aleksey's machine in #80353. Something about his machine is doing this, where the Spanish leg in CI is not seeing the same failure.

@333fred 333fred requested a review from a team as a code owner September 18, 2025 18:02
This was causing the failures on Aleksey's machine in dotnet#80353. Something about his machine is doing this, where the Spanish leg in CI is not seeing the same failure.
@AlekseyTs
Copy link
Contributor

Done with review pass (commit 1)

Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 2)

@333fred 333fred enabled auto-merge (squash) September 18, 2025 18:47
@333fred 333fred merged commit ff3bafa into dotnet:main Sep 18, 2025
23 of 24 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Sep 18, 2025
333fred added a commit that referenced this pull request Sep 18, 2025
* upstream/main: (206 commits)
  Remove bogus xlf tag (#80357)
  Fix missing type argument checks
  Add tests
  Use dotnet run file for generating compiler code (#80248)
  Only restore based on assets file changes if the actual content changed (#80341)
  make expressionbody analyzer use semanticspananalysis (#80339)
  [EnC] Use ignoreAssemblyKey: false to resolve symbol keys (#80342)
  Properly populate ExportedType metadata table in presence of extension block. (#80311)
  Propagate `params` to lambdas and local functions (#79880)
  Change 17.15 to VS 2026 preview. (#80325)
  Improve virtualproject support for older .NET SDKs (#80324)
  Update dependencies from https://github.com/dotnet/dotnet build 283666 (#80344)
  Update dependencies from https://github.com/dotnet/arcade build 20250917.6 (#80343)
  Simplifying
  Fix tests
  Fix tests
  Fix introduce variable placement in top level statements
  move to immutable types in signature help
  move to immutable types in signature help
  Fix check
  ...
@333fred 333fred deleted the remove-bogus-tag branch September 18, 2025 20:23
333fred added a commit to 333fred/roslyn that referenced this pull request Sep 18, 2025
* upstream/main: (31 commits)
  Remove bogus xlf tag (dotnet#80357)
  Fix missing type argument checks
  Add tests
  Use dotnet run file for generating compiler code (dotnet#80248)
  Only restore based on assets file changes if the actual content changed (dotnet#80341)
  make expressionbody analyzer use semanticspananalysis (dotnet#80339)
  [EnC] Use ignoreAssemblyKey: false to resolve symbol keys (dotnet#80342)
  Properly populate ExportedType metadata table in presence of extension block. (dotnet#80311)
  Propagate `params` to lambdas and local functions (dotnet#79880)
  Change 17.15 to VS 2026 preview. (dotnet#80325)
  Improve virtualproject support for older .NET SDKs (dotnet#80324)
  Update dependencies from https://github.com/dotnet/dotnet build 283666 (dotnet#80344)
  Update dependencies from https://github.com/dotnet/arcade build 20250917.6 (dotnet#80343)
  Simplifying
  Fix tests
  Fix tests
  Fix introduce variable placement in top level statements
  move to immutable types in signature help
  move to immutable types in signature help
  Fix check
  ...
@akhera99 akhera99 modified the milestones: Next, 18.0 P1, 18.0 P2 Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants