Skip to content

Extensions: Compare accessibility of implementation method with accessibility of declared extension method #81378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2025
Merged

Extensions: Compare accessibility of implementation method with accessibility of declared extension method #81378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de79969
Extensions: Compare accesibility of implementation method with accesi…
AlekseyTs Nov 20, 2025
7e6559a
Fix-up
AlekseyTs Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Compilers/CSharp/Portable/Symbols/Metadata/PE/PENamedTypeSymbol.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,7 @@ private static PEMethodSymbol GetMarkerMethodSymbol(PENamedTypeSymbol @this, Ext
continue;
}

if (candidate.DeclaredAccessibility != @this.DeclaredAccessibility)
if (candidate.DeclaredAccessibility != method.DeclaredAccessibility)
{
continue;
}
Expand Down
78 changes: 78 additions & 0 deletions src/Compilers/CSharp/Test/Emit3/Semantics/ExtensionTests2.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36877,5 +36877,83 @@ static class E4
// _ = object.Member(42);
Diagnostic(ErrorCode.ERR_AmbigExtension, "object.Member").WithArguments("E4.extension(object).Member(int)", "E1.extension(object).Member").WithLocation(1, 5));
}

[Fact]
[WorkItem("https://github.com/dotnet/roslyn/issues/81180")]
public void InternalsVisibleTo_01()
{
var sourceA =
@"
using System.Runtime.CompilerServices;
[assembly: InternalsVisibleTo(""B"")]

internal static class Extensions
{
extension(string text)
{
internal bool IsEmpty => string.IsNullOrEmpty(text);
}
}
";
var compA = CreateCompilation(sourceA, assemblyName: "A");
CompileAndVerify(compA).VerifyDiagnostics();

var sourceB =
@"
class Program
{
static void Main()
{
System.Console.Write((null as string).IsEmpty);
System.Console.Write("""".IsEmpty);
System.Console.Write(""\t"".IsEmpty);
}
}
";
var compB = CreateCompilation(sourceB, references: [compA.ToMetadataReference()], assemblyName: "B", options: TestOptions.DebugExe);
CompileAndVerify(compB, expectedOutput: "TrueTrueFalse").VerifyDiagnostics();

compB = CreateCompilation(sourceB, references: [compA.EmitToImageReference()], assemblyName: "B", options: TestOptions.DebugExe);
CompileAndVerify(compB, expectedOutput: "TrueTrueFalse").VerifyDiagnostics();
}

[Fact]
[WorkItem("https://github.com/dotnet/roslyn/issues/81180")]
public void InternalsVisibleTo_02()
{
var sourceA =
@"
using System.Runtime.CompilerServices;
[assembly: InternalsVisibleTo(""B"")]

internal static class Extensions
{
extension(string text)
{
internal bool IsEmpty() => string.IsNullOrEmpty(text);
}
}
";
var compA = CreateCompilation(sourceA, assemblyName: "A");
CompileAndVerify(compA).VerifyDiagnostics();

var sourceB =
@"
class Program
{
static void Main()
{
System.Console.Write((null as string).IsEmpty());
System.Console.Write("""".IsEmpty());
System.Console.Write(""\t"".IsEmpty());
}
}
";
var compB = CreateCompilation(sourceB, references: [compA.ToMetadataReference()], assemblyName: "B", options: TestOptions.DebugExe);
CompileAndVerify(compB, expectedOutput: "TrueTrueFalse").VerifyDiagnostics();

compB = CreateCompilation(sourceB, references: [compA.EmitToImageReference()], assemblyName: "B", options: TestOptions.DebugExe);
CompileAndVerify(compB, expectedOutput: "TrueTrueFalse").VerifyDiagnostics();
}
}

Loading