From 174a894587040ea428e65c75626d6d12908c6cdc Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Wed, 1 Jun 2022 15:05:13 -0400 Subject: [PATCH] [wasm] Fix runtime test failing due to the app running in debug mode (#70050) * [wasm] Fix runtime test failing due to the app running in debug mode Fixes https://github.com/dotnet/runtime/issues/69517 - Recent [wasm-app-host commit](6b3ea401ca20c26dbb5497b0fbbf77b3afc73374) changed `WasmApp.targets` so `WasmDebugLevel` would be set to enable debugging if `Configuration==Debug`. - this broke some runtime tests which depend on tail call optimizations, which get disabled when debugging is enabled in the runtime. - And the wasm apps for the runtime tests are being built with no configuration set, which defaults to `Debug`. Instead, propogate the config for the build to the wasm proxy (`WasmTestRunner`) projects too. Fixes https://github.com/dotnet/runtime/issues/69517 . * Revert "[wasm] Disable runtime test failing due to stack overflow (#69863)" This reverts commit 61441fae579149181dc973ae4e58eccd4beef728. --- src/tests/Directory.Build.props | 2 +- src/tests/issues.targets | 7 ------- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/src/tests/Directory.Build.props b/src/tests/Directory.Build.props index 606bf57399cbf..c0dcca32e0653 100644 --- a/src/tests/Directory.Build.props +++ b/src/tests/Directory.Build.props @@ -186,7 +186,7 @@ - /p:MSBuildEnableWorkloadResolver=false + /p:MSBuildEnableWorkloadResolver=false /p:Configuration=$(Configuration) diff --git a/src/tests/issues.targets b/src/tests/issues.targets index f2ad66e982350..7fc537a8c4a10 100644 --- a/src/tests/issues.targets +++ b/src/tests/issues.targets @@ -3291,13 +3291,6 @@ - - https://github.com/dotnet/runtime/issues/69517 - - - https://github.com/dotnet/runtime/issues/69517 - - https://github.com/dotnet/runtime/issues/54867