From 6ab00b4821b1a4bf60e12ab17e0afe214291b247 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Wed, 29 Jul 2020 12:10:35 +0300 Subject: [PATCH] [wasm] Re-enable some tests in the System.Net.WebSockets.Tests namespace (#40004) There is no repro for https://github.com/dotnet/runtime/issues/38807 at the moment so the related tests have been enabled. Two tests have been disabled due to PNSE (see https://github.com/dotnet/runtime/pull/39346). Fixes: https://github.com/dotnet/runtime/issues/38807 The test run result: `Tests run: 177, Errors: 0, Failures: 0, Skipped: 0.` --- .../Common/tests/System/Net/WebSockets/WebSocketCreateTest.cs | 2 ++ .../tests/WebSocketProtocolTests.cs | 1 - src/libraries/System.Net.WebSockets/tests/WebSocketTests.cs | 1 - 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libraries/Common/tests/System/Net/WebSockets/WebSocketCreateTest.cs b/src/libraries/Common/tests/System/Net/WebSockets/WebSocketCreateTest.cs index b48bfb0c183cef..f22a8add7d96ae 100644 --- a/src/libraries/Common/tests/System/Net/WebSockets/WebSocketCreateTest.cs +++ b/src/libraries/Common/tests/System/Net/WebSockets/WebSocketCreateTest.cs @@ -101,6 +101,7 @@ public async Task ReceiveAsync_UTF8SplitAcrossMultipleBuffers_ValidDataReceived( } [Theory] + [PlatformSpecific(~TestPlatforms.Browser)] // System.Net.Sockets is not supported on this platform. [ActiveIssue("https://github.com/dotnet/runtime/issues/34690", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)] [InlineData(0b_1000_0001, 0b_0_000_0001, false)] // fin + text, no mask + length == 1 [InlineData(0b_1100_0001, 0b_0_000_0001, true)] // fin + rsv1 + text, no mask + length == 1 @@ -147,6 +148,7 @@ public async Task ReceiveAsync_InvalidFrameHeader_AbortsAndThrowsException(byte } [Fact] + [PlatformSpecific(~TestPlatforms.Browser)] // System.Net.Sockets is not supported on this platform. [ActiveIssue("https://github.com/dotnet/runtime/issues/34690", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)] public async Task ReceiveAsync_ServerSplitHeader_ValidDataReceived() { diff --git a/src/libraries/System.Net.WebSockets.WebSocketProtocol/tests/WebSocketProtocolTests.cs b/src/libraries/System.Net.WebSockets.WebSocketProtocol/tests/WebSocketProtocolTests.cs index 7266ac96e287ca..1d8aecbda9db2f 100644 --- a/src/libraries/System.Net.WebSockets.WebSocketProtocol/tests/WebSocketProtocolTests.cs +++ b/src/libraries/System.Net.WebSockets.WebSocketProtocol/tests/WebSocketProtocolTests.cs @@ -6,7 +6,6 @@ namespace System.Net.WebSockets.Tests { - [ActiveIssue("https://github.com/dotnet/runtime/issues/38807", TestPlatforms.Browser)] public sealed class WebSocketProtocolCreateTests : WebSocketCreateTest { protected override WebSocket CreateFromStream(Stream stream, bool isServer, string subProtocol, TimeSpan keepAliveInterval) => diff --git a/src/libraries/System.Net.WebSockets/tests/WebSocketTests.cs b/src/libraries/System.Net.WebSockets/tests/WebSocketTests.cs index 892404f040d94a..ad738a00ec8645 100644 --- a/src/libraries/System.Net.WebSockets/tests/WebSocketTests.cs +++ b/src/libraries/System.Net.WebSockets/tests/WebSocketTests.cs @@ -6,7 +6,6 @@ namespace System.Net.WebSockets.Tests { - [ActiveIssue("https://github.com/dotnet/runtime/issues/38807", TestPlatforms.Browser)] public sealed class WebSocketTests : WebSocketCreateTest { protected override WebSocket CreateFromStream(Stream stream, bool isServer, string subProtocol, TimeSpan keepAliveInterval) =>