Skip to content

Commit 7aadfc0

Browse files
committed
PR feedback
1 parent 4c74553 commit 7aadfc0

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

src/tests/Regressions/coreclr/GitHub_115667/test115667.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,18 +19,16 @@ public async Task<bool> M8()
1919
}
2020
}
2121

22-
public class Program
22+
public class Runtime_115667
2323
{
2424
[Fact]
25-
public static int TestEntryPoint()
25+
public static void TestEntryPoint()
2626
{
2727
System.Runtime.Loader.AssemblyLoadContext alc = new CollectibleALC();
2828
System.Reflection.Assembly asm = alc.LoadFromAssemblyPath(System.Reflection.Assembly.GetExecutingAssembly().Location);
2929
System.Reflection.MethodInfo mi = asm.GetType(typeof(Program).FullName).GetMethod(nameof(MainInner));
3030
System.Type runtimeTy = asm.GetType(typeof(Runtime).FullName);
3131
mi.Invoke(null, new object[] { System.Activator.CreateInstance(runtimeTy) });
32-
33-
return 100;
3432
}
3533

3634
public static void MainInner(IRuntime rt)

src/tests/Regressions/coreclr/GitHub_115667/test115667.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22
<PropertyGroup>
3+
<Optimize>True</Optimize>
34
<CLRTestPriority>1</CLRTestPriority>
45
</PropertyGroup>
56
<ItemGroup>

src/tests/issues.targets

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -952,6 +952,9 @@
952952
<ExcludeList Include="$(XunitTestBinBase)/JIT/Regression/JitBlue/Runtime_90219/Runtime_90219/**">
953953
<Issue>https://github.com/dotnet/runtimelab/issues/155: Assembly.Load</Issue>
954954
</ExcludeList>
955+
<ExcludeList Include="$(XunitTestBinBase)/Regressions/coreclr/GitHub_115667/**">
956+
<Issue>https://github.com/dotnet/runtimelab/issues/155: Assembly.Load</Issue>
957+
</ExcludeList>
955958
<ExcludeList Include="$(XunitTestBinBase)/reflection\DefaultInterfaceMethods\Emit\*">
956959
<Issue>https://github.com/dotnet/runtimelab/issues/155: Reflection.Emit</Issue>
957960
</ExcludeList>
@@ -3064,6 +3067,9 @@
30643067
<ExcludeList Include="$(XunitTestBinBase)/JIT/Regression/JitBlue/Runtime_90219/Runtime_90219/*">
30653068
<Issue>Loads an assembly from file</Issue>
30663069
</ExcludeList>
3070+
<ExcludeList Include="$(XunitTestBinBase)/Regressions/coreclr/GitHub_115667/**">
3071+
<Issue>Loads an assembly from file</Issue>
3072+
</ExcludeList>
30673073
</ItemGroup>
30683074

30693075
<!-- Apple mobile NativeAOT -->

0 commit comments

Comments
 (0)