Skip to content

Commit

Permalink
Migrate various parts of the bindings code to use roots (#55530)
Browse files Browse the repository at this point in the history
We have a lot of code that passes raw pointers to managed objects around when they should really be using roots instead (i.e. root.value) so that if the GC relocates the object, they won't be using the old address. This PR migrates a bunch of that code so that it uses root objects.

A lot of code remains that does use raw objects, but I read over all of it and the cases appear to be safe because they immediately return it (or return it without calling any other functions).
  • Loading branch information
kg authored Jul 14, 2021
1 parent d953229 commit 8d365a0
Showing 1 changed file with 260 additions and 205 deletions.
Loading

0 comments on commit 8d365a0

Please sign in to comment.