diff --git a/Directory.Build.props b/Directory.Build.props index d655237beb0325..2a5cd307f5262b 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -333,8 +333,9 @@ true + false - true + true $([MSBuild]::NormalizeDirectory('$(ArtifactsBinDir)', 'XUnitLogChecker')) diff --git a/eng/pipelines/coreclr/runtime-nativeaot-outerloop.yml b/eng/pipelines/coreclr/runtime-nativeaot-outerloop.yml index c9fc6d9ac903f9..e9d21e31b1b4bb 100644 --- a/eng/pipelines/coreclr/runtime-nativeaot-outerloop.yml +++ b/eng/pipelines/coreclr/runtime-nativeaot-outerloop.yml @@ -74,7 +74,6 @@ extends: parameters: creator: dotnet-bot testRunNamePrefixSuffix: NativeAOT_$(_BuildConfig) - extraHelixArguments: /p:IsXUnitLogCheckerSupported=false # # CoreCLR NativeAOT release build (checked runtime) and libraries tests @@ -100,7 +99,6 @@ extends: parameters: creator: dotnet-bot testRunNamePrefixSuffix: NativeAOT_Checked_$(_BuildConfig) - extraHelixArguments: /p:IsXUnitLogCheckerSupported=false # # CoreCLR NativeAOT release build (checked runtime) - SizeOpt and libraries tests @@ -126,7 +124,6 @@ extends: parameters: creator: dotnet-bot testRunNamePrefixSuffix: NativeAOT_Checked_SizeOpt_$(_BuildConfig) - extraHelixArguments: /p:IsXUnitLogCheckerSupported=false # # CoreCLR NativeAOT release build (checked runtime) - SpeedOpt and libraries tests @@ -152,7 +149,6 @@ extends: parameters: creator: dotnet-bot testRunNamePrefixSuffix: NativeAOT_Checked_SpeedOpt_$(_BuildConfig) - extraHelixArguments: /p:IsXUnitLogCheckerSupported=false # # CoreCLR NativeAOT checked build and Pri0 tests @@ -187,4 +183,3 @@ extends: parameters: testGroup: innerloop liveLibrariesBuildConfig: Release - extraHelixArguments: /p:IsXUnitLogCheckerSupported=false diff --git a/eng/pipelines/runtime.yml b/eng/pipelines/runtime.yml index b939cc96d608bf..206b51f1f02ee1 100644 --- a/eng/pipelines/runtime.yml +++ b/eng/pipelines/runtime.yml @@ -380,7 +380,6 @@ extends: parameters: creator: dotnet-bot testRunNamePrefixSuffix: NativeAOT_$(_BuildConfig) - extraHelixArguments: /p:IsXUnitLogCheckerSupported=false condition: >- or( eq(dependencies.evaluate_paths.outputs['SetPathVars_libraries.containsChange'], true), diff --git a/eng/testing/RunnerTemplate.cmd b/eng/testing/RunnerTemplate.cmd index fb877e215bb0f3..652557899db534 100644 --- a/eng/testing/RunnerTemplate.cmd +++ b/eng/testing/RunnerTemplate.cmd @@ -67,6 +67,11 @@ echo DOTNET_EnableExtraSuperPmiQueries=%DOTNET_EnableExtraSuperPmiQueries% echo DOTNET_JitPath=%DOTNET_JitPath% :skip_spmi_enable_collection +echo ========================= Begin custom configuration settings ============================== +[[SetCommandsEcho]] +[[SetCommands]] +echo ========================== End custom configuration settings =============================== + :: ========================= BEGIN Test Execution ============================= echo ----- start %DATE% %TIME% =============== To repro directly: ===================================================== echo pushd %EXECUTION_DIR% diff --git a/eng/testing/RunnerTemplate.sh b/eng/testing/RunnerTemplate.sh index ef19d6c95c0744..30357f819f7d2c 100644 --- a/eng/testing/RunnerTemplate.sh +++ b/eng/testing/RunnerTemplate.sh @@ -163,6 +163,11 @@ if [ ! -z $spmi_enable_collection ]; then fi # ========================= END support for SuperPMI collection ============================== +echo ========================= Begin custom configuration settings ============================== +[[SetCommandsEcho]] +[[SetCommands]] +echo ========================== End custom configuration settings =============================== + # ========================= BEGIN Test Execution ============================= echo ----- start $(date) =============== To repro directly: ===================================================== echo pushd $EXECUTION_DIR diff --git a/eng/testing/tests.targets b/eng/testing/tests.targets index f4bf46cd298cb0..43b738d5499c45 100644 --- a/eng/testing/tests.targets +++ b/eng/testing/tests.targets @@ -69,6 +69,11 @@ + + + + + - - <_ShouldSetXUnitLogCheckerEnvVar>1 - - $(HelixPreCommands); - set __TestArchitecture=$(TargetArchitecture); - set __IsXUnitLogCheckerSupported=$(_ShouldSetXUnitLogCheckerEnvVar) - - - $(HelixPreCommands); - export __TestArchitecture=$(TargetArchitecture); - export __IsXUnitLogCheckerSupported=$(_ShouldSetXUnitLogCheckerEnvVar) - - - - - + +