From b6b3bfadb95ceb206198a832b7201344b9b52b9e Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Thu, 13 Oct 2022 00:20:32 +0000 Subject: [PATCH] [wasm] Download latest stable version of chrome for testing - Rename provisioning.targets to wasm-provisioning.targets - Use the new task to install chrome, and chromedriver --- eng/testing/ProvisioningVersions.props | 45 +++---- eng/testing/provisioning.targets | 97 ------------- eng/testing/tests.wasm.targets | 21 ++- eng/testing/wasm-provisioning.targets | 127 ++++++++++++++++++ .../Wasm.Build.Tests/Wasm.Build.Tests.csproj | 2 +- .../DebuggerTestSuite.csproj | 2 +- 6 files changed, 171 insertions(+), 123 deletions(-) delete mode 100644 eng/testing/provisioning.targets create mode 100644 eng/testing/wasm-provisioning.targets diff --git a/eng/testing/ProvisioningVersions.props b/eng/testing/ProvisioningVersions.props index 63fc5a13c7e77c..ef88b2d9e4921a 100644 --- a/eng/testing/ProvisioningVersions.props +++ b/eng/testing/ProvisioningVersions.props @@ -1,31 +1,30 @@ - + + stable + + win + linux + mac + + false + + $(ArtifactsBinDir)chrome\ + $(ArtifactsBinDir)chromedriver\ + + + 3 + + $(ArtifactsBinDir)firefox\ + $([MSBuild]::NormalizePath($(FirefoxDir), '.install-firefox-$(FirefoxRevision).stamp')) + + - 972765 - https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/$(ChromiumRevision)/chrome-linux.zip - https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/$(ChromiumRevision)/chromedriver_linux64.zip - chrome-linux - chromedriver_linux64 - chrome 97.0.1 https://ftp.mozilla.org/pub/firefox/releases/$(FirefoxRevision)/linux-x86_64/en-US/firefox-$(FirefoxRevision).tar.bz2 firefox - - - 972766 - https://storage.googleapis.com/chromium-browser-snapshots/Win_x64/$(ChromiumRevision)/chrome-win.zip - https://storage.googleapis.com/chromium-browser-snapshots/Win_x64/$(ChromiumRevision)/chromedriver_win32.zip - chrome-win - chromedriver_win32 - chrome.exe - diff --git a/eng/testing/provisioning.targets b/eng/testing/provisioning.targets deleted file mode 100644 index 040f423fa19f92..00000000000000 --- a/eng/testing/provisioning.targets +++ /dev/null @@ -1,97 +0,0 @@ - - - $(ArtifactsBinDir)chrome\ - $(ArtifactsBinDir)chromedriver\ - $(ArtifactsBinDir)\ - $(BrowserStampDir).install-chrome-$(ChromiumRevision).stamp - $(BrowserStampDir).install-chromedriver-$(ChromiumRevision).stamp - $(ArtifactsBinDir)firefox\ - $(BrowserStampDir).install-firefox-$(FirefoxRevision).stamp - - - - - - - - <_StampFile Include="$(BrowserStampDir).install-chrome*.stamp" /> - - - - - - - - - - - - <_ChromeBinaryPath>$([MSBuild]::NormalizePath($(ChromeDir), $(ChromiumDirName), $(ChromiumBinaryName))) - - - - - - - - - - - - - <_StampFile Include="$(BrowserStampDir).install-chromedriver*.stamp" /> - - - - - - - - - - - - <_ChromeDriverBinaryPath>$([MSBuild]::NormalizePath($(ChromeDriverDir), $(ChromeDriverDirName), 'chromedriver')) - - - - - - - - - - - - <_StampFile Include="$(BrowserStampDir).install-firefox*.stamp" /> - - - - - - - - - - - - - <_FirefoxBinaryPath>$([MSBuild]::NormalizePath($(FirefoxDir), $(FirefoxBinaryName))) - - - - - - - - - diff --git a/eng/testing/tests.wasm.targets b/eng/testing/tests.wasm.targets index 2c94f1fa8f1b36..ca7adf3e2987ae 100644 --- a/eng/testing/tests.wasm.targets +++ b/eng/testing/tests.wasm.targets @@ -30,8 +30,15 @@ <_UseWasmSymbolicator Condition="'$(TestTrimming)' != 'true'">true true false + _GetWorkloadsToInstall;$(InstallWorkloadUsingArtifactsDependsOn) + + true + + true @@ -45,6 +52,9 @@ helix helix local + + <_WasmBrowserPathForTests Condition="'$(BROWSER_PATH_FOR_TESTS)' != ''">$(BROWSER_PATH_FOR_TESTS) + <_WasmBrowserPathForTests Condition="'$(_WasmBrowserPathForTests)' == '' and '$(InstallChromeForTests)' == 'true'">$(ChromeBinaryPath) @@ -93,6 +103,7 @@ <_XHarnessArgs >$(_XHarnessArgs) -s dotnet.js.symbols <_XHarnessArgs Condition="'$(_UseWasmSymbolicator)' == 'true'" >$(_XHarnessArgs) --symbol-patterns wasm-symbol-patterns.txt <_XHarnessArgs Condition="'$(_UseWasmSymbolicator)' == 'true'" >$(_XHarnessArgs) --symbolicator WasmSymbolicator.dll,Microsoft.WebAssembly.Internal.SymbolicatorWrapperForXHarness + <_XHarnessArgs Condition="'$(_WasmBrowserPathForTests)' != ''" >$(_XHarnessArgs) "--browser-path=$(_WasmBrowserPathForTests)" <_XHarnessArgs Condition="'$(WasmXHarnessArgsCli)' != ''" >$(_XHarnessArgs) $(WasmXHarnessArgsCli) @@ -315,7 +326,8 @@ - + + <_NodeNpmModuleString Include="%(NodeNpmModule.Identity):%(NodeNpmModule.Alias)" /> @@ -329,10 +341,17 @@ + + + + + + + diff --git a/eng/testing/wasm-provisioning.targets b/eng/testing/wasm-provisioning.targets new file mode 100644 index 00000000000000..ae0261c4f29765 --- /dev/null +++ b/eng/testing/wasm-provisioning.targets @@ -0,0 +1,127 @@ + + + + + chrome-linux + chromedriver_linux64 + chrome + chromedriver + <_ChromeOSPrefix>Linux_x64 + + + + chrome-win + chromedriver_win32 + chrome.exe + chromedriver.exe + <_ChromeOSPrefix>Win_x64 + + + + <_BrowserStampDir>$(ArtifactsBinDir)\ + $([MSBuild]::NormalizePath($(ChromeDir), $(ChromeDirName), $(ChromeBinaryName))) + $([MSBuild]::NormalizePath($(ChromeDriverDir), $(ChromeDriverDirName), $(ChromeDriverBinaryName))) + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + <_StampFile Include="$(_BrowserStampDir).install-firefox*.stamp" /> + + + + + + + + + + + + + <_FirefoxBinaryPath>$([MSBuild]::NormalizePath($(FirefoxDir), $(FirefoxBinaryName))) + + + + + + + + + + + + + + + + + + + + + $(_ChromeBaseSnapshotUrl)/chrome-linux.zip + $(_ChromeBaseSnapshotUrl)/chromedriver_linux64.zip + + + $(_ChromeBaseSnapshotUrl)/chrome-win.zip + $(_ChromeBaseSnapshotUrl)/chromedriver_win32.zip + + + + $([MSBuild]::NormalizePath('$(ChromeDir)', '.install-$(ChromeVersion)-$(ChromeRevision).stamp')) + $([MSBuild]::NormalizePath('$(ChromeDriverDir)', '.install-$(ChromeVersion)-$(ChromeRevision).stamp')) + + + diff --git a/src/mono/wasm/Wasm.Build.Tests/Wasm.Build.Tests.csproj b/src/mono/wasm/Wasm.Build.Tests/Wasm.Build.Tests.csproj index 7a9c16c6a34bdd..b84e9178339445 100644 --- a/src/mono/wasm/Wasm.Build.Tests/Wasm.Build.Tests.csproj +++ b/src/mono/wasm/Wasm.Build.Tests/Wasm.Build.Tests.csproj @@ -20,7 +20,7 @@ true - + RunScriptTemplate.cmd diff --git a/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestSuite.csproj b/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestSuite.csproj index 45e5d54b85f467..8032934e68a946 100644 --- a/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestSuite.csproj +++ b/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestSuite.csproj @@ -12,7 +12,7 @@ true - +