-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Closed
dotnet/coreclr
#23938Description
The following methods should be removed from the Rune sources since they were renamed in a recent commit. (The old names were left in the sources temporarily to avoid build breaks.) Left side is the old name, right side is the new name.
TryEncode -> TryEncodeToUtf16
TryEncodeAsUtf8Bytes -> TryEncodeToUtf8
DecodeUtf16 -> DecodeFromUtf16
DecodeUtf16FromEnd -> DecodeLastFromUtf16
DecodeUtf8 -> DecodeFromUtf8
DecodeUtf8FromEnd -> DecodeLastFromUtf8At the same time we should re-enable the test suppressed below.
At the same time we should also fix up the parameter names on the Utf8 static class. The parameter names in the reference assembly in corefx are correct; the parameter names in the actual implementation in coreclr are incorrect.