Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TargetPlatformMonikers for net5.0 and above targetFrameworks. #43646

Closed
Anipik opened this issue Oct 20, 2020 · 4 comments · Fixed by #43965
Closed

Use TargetPlatformMonikers for net5.0 and above targetFrameworks. #43646

Anipik opened this issue Oct 20, 2020 · 4 comments · Fixed by #43965

Comments

@Anipik
Copy link
Contributor

Anipik commented Oct 20, 2020

Sdk added support for platforms in the targetFramework strings. Many of our projects have platform specific tfms. Currently we have workarounds to make nuget and sdk understand these custom frameworks,
But with the new TargetFramework feature we can remove those workarounds for net5.0 and above tfms.

The pre-requiste to this issue is #32451 because the sdk doesnt support "_" in the name.

cc @ericstj @ViktorHofer @safern

@ghost
Copy link

ghost commented Oct 21, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

@ViktorHofer
Copy link
Member

I support this to largely mitigate the restore issues inside Visual Studio. @Anipik does this require dotnet/project-system#6656 to be fixed as well?

@Anipik
Copy link
Contributor Author

Anipik commented Oct 21, 2020

@Anipik does this require dotnet/project-system#6656 to be fixed as well?

Not in particular, this warning could be seem in customer projects as well but it does not interfere with any VS experience.

@ViktorHofer
Copy link
Member

Introducing a new warning isn't ideal but maybe this issue gets away anyway before this is completed.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants