Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser WebSockets tests #44666

Closed
5 tasks done
lewing opened this issue Nov 13, 2020 · 3 comments
Closed
5 tasks done

Browser WebSockets tests #44666

lewing opened this issue Nov 13, 2020 · 3 comments
Assignees
@pavelsavara
Labels
arch-wasm WebAssembly architecture area-System.Net test-enhancement Improvements of test source code
Milestone
6.0.0

Comments

@lewing
Copy link
Member

lewing commented Nov 13, 2020 •
edited by pavelsavara
Loading

We still don't have good functional tests for browser WebSockets in CI in inner or outer loops as evidenced by #44551 we need to resolve this now that we are unblocked on the xharness side.

  • Partial send {endOfMessage: false} System.Net.WebSockets.Client.Tests.SendReceiveTest.SendReceive_PartialMessageDueToSmallReceiveBuffer_Success
  • Text/Binary System.Net.WebSockets.Client.Tests.ConnectTest.EchoBinaryMessage_Success, EchoTextMessage_Success
  • Cancellation System.Net.WebSockets.Client.Tests.CancelTest
  • Abort System.Net.WebSockets.Client.Tests.AbortTest
  • SendAsync buffering/completion System.Net.WebSockets.Client.Tests.ArraySegmentSendReceiveTest
@lewing lewing added arch-wasm WebAssembly architecture test-enhancement Improvements of test source code labels Nov 13, 2020
@lewing lewing added this to the 6.0.0 milestone Nov 13, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-System.Net untriaged New issue has not been triaged by the area owner labels Nov 13, 2020
@ghost
Copy link

ghost commented Nov 13, 2020

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details
Description:

We still don't have good functional tests for browser WebSockets in CI in inner or outer loops as evidenced by #44551 we need to resolve this now that we are unblocked on the xharness side.
Author: lewing
Assignees: kjpou1
Labels:

arch-wasm, area-System.Net, test enhancement, untriaged
Milestone: [object Object]

@lewing lewing removed the untriaged New issue has not been triaged by the area owner label Nov 13, 2020
@kjpou1
Copy link
Contributor

kjpou1 commented Nov 16, 2020

Looking into it

This was referenced Nov 16, 2020
Merged
Merged
@lewing lewing mentioned this issue Dec 1, 2020
Closed
This was referenced Dec 2, 2020
Merged
Closed
Merged
Closed
Closed
@kjpou1 kjpou1 mentioned this issue Dec 9, 2020
Closed
@kjpou1 kjpou1 mentioned this issue Feb 11, 2021
Merged
@pavelsavara pavelsavara assigned pavelsavara and unassigned kjpou1 Jun 21, 2021
@pavelsavara
Copy link
Member

@lewing I believe that the System.Net.WebSockets.Client.Tests functional tests with Xharness server now cover what is asked here.
The browser doesn't support all the endOfMessage: false scenarios, see #46982.

@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Net test-enhancement Improvements of test source code
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
4 participants
@lewing @pavelsavara @kjpou1 @Dotnet-GitSync-Bot