Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QUIC: revisit support for ServerCertificateContext #53507

Closed
wfurt opened this issue May 31, 2021 · 3 comments · Fixed by #68189
Closed

QUIC: revisit support for ServerCertificateContext #53507

wfurt opened this issue May 31, 2021 · 3 comments · Fixed by #68189
Labels
api-needs-work API needs work before it is approved, it is NOT ready for implementation area-System.Net.Quic
Milestone
7.0.0

Comments

@wfurt
Copy link
Member

wfurt commented May 31, 2021

#53175 added support for ServerCertificateContext. While it is functionally complete, it uses reflection to access private members of the ServerCertificateContext. This happens once per server so there may not be performance issue but it may become maintenance hassle.
We should look into new API so we can access everything directly. (or find some other solution)
@ghost
Copy link

ghost commented May 31, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

#53175 added support for ServerCertificateContext. While it is functionally complete, it uses reflection to access private members of the ServerCertificateContext. This happens once per server so there may not be performance issue but it may become maintenance hassle.
We should look into new API so we can access everything directly. (or find some other solution)

Author: wfurt
Assignees: -
Labels:

area-System.Net.Quic
Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label May 31, 2021
@wfurt wfurt mentioned this issue May 31, 2021
Merged
@karelz karelz added this to the Future milestone Jun 3, 2021
@karelz karelz added enhancement Product code improvement that does NOT require public API changes/additions and removed untriaged New issue has not been triaged by the area owner labels Jun 3, 2021
@wfurt wfurt mentioned this issue Jun 15, 2021
Closed
@wfurt wfurt mentioned this issue Jul 12, 2021
Merged
@karelz karelz modified the milestones: Future, 7.0.0 Oct 26, 2021
@karelz karelz added api-needs-work API needs work before it is approved, it is NOT ready for implementation and removed enhancement Product code improvement that does NOT require public API changes/additions labels Oct 26, 2021
@karelz
Copy link
Member

karelz commented Oct 26, 2021

Triage: We should remove reflection in 7.0, so we will need the new APIs in SslStream.

@rzikm
Copy link
Member

rzikm commented Apr 8, 2022

Proposal to make ServerCertificateContext properties public: #67552

@wfurt wfurt mentioned this issue Apr 18, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Apr 18, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label May 2, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jun 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
api-needs-work API needs work before it is approved, it is NOT ready for implementation area-System.Net.Quic
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

avoid Reflection in Quic wfurt/runtime
3 participants
@karelz @wfurt @rzikm