Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failure System.Net.NameResolution.Tests.GetHostAddressesTest_Cancellation.DnsGetHostAddresses_PostCancelledToken_Throws #69993

Closed
VincentBu opened this issue May 31, 2022 · 4 comments · Fixed by #70044
Closed

Test failure System.Net.NameResolution.Tests.GetHostAddressesTest_Cancellation.DnsGetHostAddresses_PostCancelledToken_Throws #69993

VincentBu opened this issue May 31, 2022 · 4 comments · Fixed by #70044
Assignees
@rzikm
Labels
arch-x86 area-System.Net blocking-clean-ci-optional Blocking optional rolling runs JitStress CLR JIT issues involving JIT internal stress modes os-windows
Milestone
7.0.0

Comments

@VincentBu
Copy link
Contributor

VincentBu commented May 31, 2022 •
edited by rzikm
Loading

Run: runtime-coreclr libraries-jitstress 20220530.1

Failed test:

net7.0-windows-Release-x86-CoreCLR_checked-jitstress1-Windows.10.Amd64.Open

- System.Net.NameResolution.Tests.GetHostAddressesTest_Cancellation.DnsGetHostAddresses_PostCancelledToken_Throws

Error message:

Assert.Throws() Failure
Expected: typeof(System.OperationCanceledException)
Actual:   typeof(System.Net.Sockets.SocketException): No such host is known.
---- System.Net.Sockets.SocketException : No such host is known.


Stack trace
   at System.Net.NameResolutionPal.ProcessResult(SocketError errorCode, GetAddrInfoExContext* context) in /_/src/libraries/System.Net.NameResolution/src/System/Net/NameResolutionPal.Windows.cs:line 220
   at System.Net.NameResolutionPal.GetAddressInfoExCallback(Int32 error, Int32 bytes, NativeOverlapped* overlapped) in /_/src/libraries/System.Net.NameResolution/src/System/Net/NameResolutionPal.Windows.cs:line 192
--- End of stack trace from previous location ---
----- Inner Stack Trace -----
   at System.Net.NameResolutionPal.ProcessResult(SocketError errorCode, GetAddrInfoExContext* context) in /_/src/libraries/System.Net.NameResolution/src/System/Net/NameResolutionPal.Windows.cs:line 220
   at System.Net.NameResolutionPal.GetAddressInfoExCallback(Int32 error, Int32 bytes, NativeOverlapped* overlapped) in /_/src/libraries/System.Net.NameResolution/src/System/Net/NameResolutionPal.Windows.cs:line 192
--- End of stack trace from previous location ---

No Kusto information.

CI leg: runtime-coreclr libraries-jitstress

Date branch OS
2022-05-30T07:55:59.41Z main Windows.10.Amd64.Open
2022-05-31T08:14:01.729Z main Windows.10.Amd64.Open
@VincentBu VincentBu added arch-x86 area-System.Net os-windows JitStress CLR JIT issues involving JIT internal stress modes blocking-clean-ci-optional Blocking optional rolling runs labels May 31, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label May 31, 2022
@ghost
Copy link

ghost commented May 31, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Run: runtime-coreclr libraries-jitstress 20220530.1

Failed test:

net7.0-windows-Release-x86-CoreCLR_checked-jitstress1-Windows.10.Amd64.Open

- System.Net.NameResolution.Tests.GetHostAddressesTest_Cancellation.DnsGetHostAddresses_PostCancelledToken_Throws

Error message:

Assert.Throws() Failure
Expected: typeof(System.OperationCanceledException)
Actual:   typeof(System.Net.Sockets.SocketException): No such host is known.
---- System.Net.Sockets.SocketException : No such host is known.


Stack trace
   at System.Net.NameResolutionPal.ProcessResult(SocketError errorCode, GetAddrInfoExContext* context) in /_/src/libraries/System.Net.NameResolution/src/System/Net/NameResolutionPal.Windows.cs:line 220
   at System.Net.NameResolutionPal.GetAddressInfoExCallback(Int32 error, Int32 bytes, NativeOverlapped* overlapped) in /_/src/libraries/System.Net.NameResolution/src/System/Net/NameResolutionPal.Windows.cs:line 192
--- End of stack trace from previous location ---
----- Inner Stack Trace -----
   at System.Net.NameResolutionPal.ProcessResult(SocketError errorCode, GetAddrInfoExContext* context) in /_/src/libraries/System.Net.NameResolution/src/System/Net/NameResolutionPal.Windows.cs:line 220
   at System.Net.NameResolutionPal.GetAddressInfoExCallback(Int32 error, Int32 bytes, NativeOverlapped* overlapped) in /_/src/libraries/System.Net.NameResolution/src/System/Net/NameResolutionPal.Windows.cs:line 192
--- End of stack trace from previous location ---

No Kusto information.

Author: VincentBu
Assignees: -
Labels:

arch-x86, area-System.Net, os-windows, JitStress, blocking-clean-ci-optional
Milestone: -

@rzikm
Copy link
Member

rzikm commented May 31, 2022

The test contains following comment:

        // This test might flake if the cancellation token takes too long to trigger:
        // It's a race between the DNS server getting back to us and the cancellation processing.

We should probably compensate for it the tests flakiness.

@wfurt
Copy link
Member

wfurt commented May 31, 2022

... or skip for jitstress....

@rzikm rzikm mentioned this issue May 31, 2022
Merged
@runfoapp runfoapp bot mentioned this issue May 31, 2022
Closed
@jakobbotsch
Copy link
Member

jakobbotsch commented May 31, 2022 •
edited
Loading

... or skip for jitstress....

We run a lot of jitstress legs so often flaky tests are exposed under jitstress simply by chance. Even if you skip it for jitstress it is likely this problem will show up in other future runs.

Edit: e.g. here is a standard runtime failure: https://dev.azure.com/dnceng/public/_build/results?buildId=1798159&view=ms.vss-test-web.build-test-results-tab&runId=47979192&resultId=177258&paneView=debug

@jakobbotsch jakobbotsch mentioned this issue May 31, 2022
Merged
@rzikm rzikm self-assigned this May 31, 2022
@rzikm rzikm mentioned this issue May 31, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label May 31, 2022
@ghost ghost removed untriaged New issue has not been triaged by the area owner in-pr There is an active PR which will close this issue when it is merged labels Jun 1, 2022
@rzikm rzikm mentioned this issue Jun 1, 2022
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Jul 1, 2022
@karelz karelz added this to the 7.0.0 milestone Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rzikm rzikm

Labels
arch-x86 area-System.Net blocking-clean-ci-optional Blocking optional rolling runs JitStress CLR JIT issues involving JIT internal stress modes os-windows
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Fix flakyness of DnsGetHostAddresses_PostCancelledToken_Throws rzikm/dotnet-runtime
5 participants
@karelz @jakobbotsch @wfurt @rzikm @VincentBu