Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failure JIT\\Directed\\StructABI\\StructABI\\StructABI.cmd #77362

Closed
v-wenyuxu opened this issue Oct 24, 2022 · 4 comments · Fixed by #77378
Closed

Test failure JIT\\Directed\\StructABI\\StructABI\\StructABI.cmd #77362

v-wenyuxu opened this issue Oct 24, 2022 · 4 comments · Fixed by #77378
Assignees
@SingleAccretion
Labels
arch-x86 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs JitStress CLR JIT issues involving JIT internal stress modes os-linux Linux OS (any supported distro) os-windows

Comments

@v-wenyuxu
Copy link

Run: runtime-coreclr jitstress 20221022.1

Failed test:

coreclr windows x86 Checked jitstress1_tiered @ Windows.10.Amd64.Open
- JIT\\Directed\\StructABI\\StructABI\\StructABI.cmd

coreclr Linux arm Checked jitstress1_tiered @ (Ubuntu.1804.Arm32.Open)Ubuntu.1804.Armarch.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-helix-arm32v7-bfcd90a-20200121150440
- JIT/Directed/StructABI/StructABI/StructABI.sh

coreclr windows x86 Checked jitstress1 @ Windows.10.Amd64.Open
- JIT\\Directed\\StructABI\\StructABI\\StructABI.cmd

coreclr Linux arm Checked jitstress2 @ (Ubuntu.1804.Arm32.Open)Ubuntu.1804.Armarch.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-helix-arm32v7-bfcd90a-20200121150440
- JIT/Directed/StructABI/StructABI/StructABI.sh

coreclr windows x86 Checked jitstress2 @ Windows.10.Amd64.Open
- JIT\\Directed\\StructABI\\StructABI\\StructABI.cmd

coreclr Linux arm Checked jitstress1 @ (Ubuntu.1804.Arm32.Open)Ubuntu.1804.Armarch.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-helix-arm32v7-bfcd90a-20200121150440
- JIT/Directed/StructABI/StructABI/StructABI.sh

coreclr Linux arm Checked jitstress2_tiered @ (Ubuntu.1804.Arm32.Open)Ubuntu.1804.Armarch.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-helix-arm32v7-bfcd90a-20200121150440
- JIT/Directed/StructABI/StructABI/StructABI.sh

coreclr windows x86 Checked jitstress2_tiered @ Windows.10.Amd64.Open
- JIT\\Directed\\StructABI\\StructABI\\StructABI.cmd

Error message:

Assert failure(PID 5372 [0x000014fc], Thread: 8388 [0x20c4]): Assertion failed '((lclNode->gtFlags & GTF_VAR_DEF) != 0) && (((lclNode->gtFlags & GTF_VAR_USEASG) != 0) == !isFullDef)' in 'InlineArray1:Get():InlineArray1' during 'SSA: insert phis' (IL size 42; hash 0x77245012; Tier0-FullOpts)

File: D:\a\_work\1\s\src\coreclr\jit\ssabuilder.cpp Line: 753
Image: C:\h\w\B2970998\p\corerun.exe
Return code:      1
Raw output file:      C:\h\w\B2970998\w\C84E0AD9\uploads\Reports\JIT.Directed\StructABI\StructABI\StructABI.output.txt
Raw output:
BEGIN EXECUTION
"C:\h\w\B2970998\p\corerun.exe" -p "System.Reflection.Metadata.MetadataUpdater.IsSupported=false"  StructABI.dll
Expected: 100
Actual: -1073740286
END EXECUTION - FAILED
FAILED
Test Harness Exitcode is : 1
To run the test:

set CORE_ROOT=C:\h\w\B2970998\p
C:\h\w\B2970998\w\C84E0AD9\e\JIT\Directed\StructABI\StructABI\StructABI.cmd
Expected: True
Actual:   False


Stack trace
   at JIT_Directed._StructABI_StructABI_StructABI_._StructABI_StructABI_StructABI_cmd()
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
@v-wenyuxu v-wenyuxu added arch-x86 os-linux Linux OS (any supported distro) os-windows JitStress CLR JIT issues involving JIT internal stress modes blocking-clean-ci-optional Blocking optional rolling runs labels Oct 24, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Oct 24, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 24, 2022
@ghost
Copy link

ghost commented Oct 24, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Run: runtime-coreclr jitstress 20221022.1

Failed test:

coreclr windows x86 Checked jitstress1_tiered @ Windows.10.Amd64.Open
- JIT\\Directed\\StructABI\\StructABI\\StructABI.cmd

coreclr Linux arm Checked jitstress1_tiered @ (Ubuntu.1804.Arm32.Open)Ubuntu.1804.Armarch.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-helix-arm32v7-bfcd90a-20200121150440
- JIT/Directed/StructABI/StructABI/StructABI.sh

coreclr windows x86 Checked jitstress1 @ Windows.10.Amd64.Open
- JIT\\Directed\\StructABI\\StructABI\\StructABI.cmd

coreclr Linux arm Checked jitstress2 @ (Ubuntu.1804.Arm32.Open)Ubuntu.1804.Armarch.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-helix-arm32v7-bfcd90a-20200121150440
- JIT/Directed/StructABI/StructABI/StructABI.sh

coreclr windows x86 Checked jitstress2 @ Windows.10.Amd64.Open
- JIT\\Directed\\StructABI\\StructABI\\StructABI.cmd

coreclr Linux arm Checked jitstress1 @ (Ubuntu.1804.Arm32.Open)Ubuntu.1804.Armarch.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-helix-arm32v7-bfcd90a-20200121150440
- JIT/Directed/StructABI/StructABI/StructABI.sh

coreclr Linux arm Checked jitstress2_tiered @ (Ubuntu.1804.Arm32.Open)Ubuntu.1804.Armarch.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-helix-arm32v7-bfcd90a-20200121150440
- JIT/Directed/StructABI/StructABI/StructABI.sh

coreclr windows x86 Checked jitstress2_tiered @ Windows.10.Amd64.Open
- JIT\\Directed\\StructABI\\StructABI\\StructABI.cmd

Error message:

Assert failure(PID 5372 [0x000014fc], Thread: 8388 [0x20c4]): Assertion failed '((lclNode->gtFlags & GTF_VAR_DEF) != 0) && (((lclNode->gtFlags & GTF_VAR_USEASG) != 0) == !isFullDef)' in 'InlineArray1:Get():InlineArray1' during 'SSA: insert phis' (IL size 42; hash 0x77245012; Tier0-FullOpts)

File: D:\a\_work\1\s\src\coreclr\jit\ssabuilder.cpp Line: 753
Image: C:\h\w\B2970998\p\corerun.exe
Return code:      1
Raw output file:      C:\h\w\B2970998\w\C84E0AD9\uploads\Reports\JIT.Directed\StructABI\StructABI\StructABI.output.txt
Raw output:
BEGIN EXECUTION
"C:\h\w\B2970998\p\corerun.exe" -p "System.Reflection.Metadata.MetadataUpdater.IsSupported=false"  StructABI.dll
Expected: 100
Actual: -1073740286
END EXECUTION - FAILED
FAILED
Test Harness Exitcode is : 1
To run the test:

set CORE_ROOT=C:\h\w\B2970998\p
C:\h\w\B2970998\w\C84E0AD9\e\JIT\Directed\StructABI\StructABI\StructABI.cmd
Expected: True
Actual:   False


Stack trace
   at JIT_Directed._StructABI_StructABI_StructABI_._StructABI_StructABI_StructABI_cmd()
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
Author: v-wenyuxu
Assignees: -
Labels:

arch-x86, os-linux, os-windows, JitStress, area-CodeGen-coreclr, untriaged, blocking-clean-ci-optional
Milestone: -

@jakobbotsch
Copy link
Member

cc @SingleAccretion, related to some of the recent SSA work?

@SingleAccretion
Copy link
Contributor

Indeed, the assert was updated to check USEASG is set correctly as well; suspect that has revealed some pre-existing issues. Will take a look.

@SingleAccretion SingleAccretion self-assigned this Oct 24, 2022
@SingleAccretion
Copy link
Contributor

The issue here is that we do not update the def flags when we unroll a loop (because we don't remorph the cloned statements). I can see a couple solutions:

  1. Relax the assert to only apply to non-address-exposed variables.
  2. Remorph statements after cloning them.
  3. Handle this inside gtCloneExpr.

I am inclined to go with 3 as the least impactful change. In due time, all this flag setting and resetting will go away anyway.

@SingleAccretion SingleAccretion mentioned this issue Oct 24, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Oct 24, 2022
@runfoapp runfoapp bot mentioned this issue Oct 24, 2022
Closed
@EgorBo EgorBo mentioned this issue Oct 24, 2022
Closed
@ghost ghost removed in-pr There is an active PR which will close this issue when it is merged untriaged New issue has not been triaged by the area owner labels Oct 24, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@SingleAccretion SingleAccretion

Labels
arch-x86 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs JitStress CLR JIT issues involving JIT internal stress modes os-linux Linux OS (any supported distro) os-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update def flags in gtCloneExpr SingleAccretion/runtime
3 participants
@jakobbotsch @SingleAccretion @v-wenyuxu