Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new listener to EventPipeEventDispatcher temporarily stops emitting events for existing sessions #90052

Open
davmason opened this issue Aug 4, 2023 · 0 comments
Labels
area-Tracing-coreclr enhancement Product code improvement that does NOT require public API changes/additions
Milestone

Comments

@davmason
Copy link
Member

davmason commented Aug 4, 2023

In EventPipeEventDispatcher we currently have a shared session for all EventListeners, whenever a new listener is added we will stop the existing session and then start a new session with the combined keywords/level. This has the side effect that for existing listeners we will drop events that happen between stopping the old session and starting the new one, as well as any unread events from the old session when we stop delivering events.

We can address this by changing the logic to update the keywords/level rather than starting and stopping. I have a first attempt at this at https://github.com/davmason/runtime/tree/eventpipe_update

@davmason davmason added this to the 9.0.0 milestone Aug 4, 2023
@tommcdon tommcdon added the enhancement Product code improvement that does NOT require public API changes/additions label Nov 18, 2023
@tommcdon tommcdon modified the milestones: 9.0.0, Future Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Tracing-coreclr enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Development

No branches or pull requests

2 participants