From 79dd4f303089605f63b80c8afd3b9ee766c94330 Mon Sep 17 00:00:00 2001 From: Matous Kozak Date: Mon, 25 Mar 2024 09:07:34 +0100 Subject: [PATCH 01/10] [android] disable System.Security.Cryptography.X509Certificates.Tests.ChainTests --- .../tests/X509Certificates/ChainTests.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/libraries/System.Security.Cryptography/tests/X509Certificates/ChainTests.cs b/src/libraries/System.Security.Cryptography/tests/X509Certificates/ChainTests.cs index 775c05b7fc7ee..210f36dcf6d57 100644 --- a/src/libraries/System.Security.Cryptography/tests/X509Certificates/ChainTests.cs +++ b/src/libraries/System.Security.Cryptography/tests/X509Certificates/ChainTests.cs @@ -1270,6 +1270,7 @@ public static void BuildChainForSelfSignedSha3Certificate() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/100224", typeof(PlatformDetection), nameof(PlatformDetection.IsAndroid), nameof(PlatformDetection.IsArmOrArm64Process))] public static void BuildChainForSelfSignedCertificate_WithSha256RsaSignature() { using (ChainHolder chainHolder = new ChainHolder()) @@ -1288,6 +1289,7 @@ public static void BuildChainForSelfSignedCertificate_WithSha256RsaSignature() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/100224", typeof(PlatformDetection), nameof(PlatformDetection.IsAndroid), nameof(PlatformDetection.IsArmOrArm64Process))] public static void BuildChainForSelfSignedCertificate_WithUnknownOidSignature() { using (ChainHolder chainHolder = new ChainHolder()) From 92ee6ebb4631877639cb155de5d4c7e9a1b28834 Mon Sep 17 00:00:00 2001 From: Matous Kozak Date: Mon, 25 Mar 2024 09:14:36 +0100 Subject: [PATCH 02/10] Disable fullAOT-llvm pipelines due to OOM issues --- eng/pipelines/runtime-llvm.yml | 55 +++++++++++++++++----------------- 1 file changed, 28 insertions(+), 27 deletions(-) diff --git a/eng/pipelines/runtime-llvm.yml b/eng/pipelines/runtime-llvm.yml index 6338116afd410..9a8ee3a4d15ff 100644 --- a/eng/pipelines/runtime-llvm.yml +++ b/eng/pipelines/runtime-llvm.yml @@ -174,30 +174,31 @@ extends: eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_installer.containsChange'], true), eq(variables['isRollingBuild'], true)) - - template: /eng/pipelines/common/platform-matrix.yml - parameters: - jobTemplate: /eng/pipelines/common/global-build-job.yml - helixQueuesTemplate: /eng/pipelines/coreclr/templates/helix-queues-setup.yml - buildConfig: release - runtimeFlavor: mono - platforms: - - linux_x64 - - linux_arm64 - jobParameters: - testGroup: innerloop - nameSuffix: AllSubsets_Mono_LLVMFullAOT_RuntimeTests - buildArgs: -s mono+clr.iltools+clr.hosts+libs+host+packs -c $(_BuildConfig) -lc ${{ variables.debugOnPrReleaseOnRolling }} - /p:MonoEnableLLVM=true /p:MonoAOTEnableLLVM=true /p:MonoBundleLLVMOptimizer=true - postBuildSteps: - - template: /eng/pipelines/common/templates/runtimes/build-runtime-tests-and-send-to-helix.yml - parameters: - creator: dotnet-bot - testRunNamePrefixSuffix: Mono_Release - llvmAotStepContainer: linux_x64_llvmaot - runtimeVariant: llvmfullaot - condition: >- - or( - eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_libraries.containsChange'], true), - eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_mono_excluding_wasm.containsChange'], true), - eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_installer.containsChange'], true), - eq(variables['isRollingBuild'], true)) + # Disabled due to OOM issues https://github.com/dotnet/runtime/issues/90427 + # - template: /eng/pipelines/common/platform-matrix.yml + # parameters: + # jobTemplate: /eng/pipelines/common/global-build-job.yml + # helixQueuesTemplate: /eng/pipelines/coreclr/templates/helix-queues-setup.yml + # buildConfig: release + # runtimeFlavor: mono + # platforms: + # - linux_x64 + # - linux_arm64 + # jobParameters: + # testGroup: innerloop + # nameSuffix: AllSubsets_Mono_LLVMFullAOT_RuntimeTests + # buildArgs: -s mono+clr.iltools+clr.hosts+libs+host+packs -c $(_BuildConfig) -lc ${{ variables.debugOnPrReleaseOnRolling }} + # /p:MonoEnableLLVM=true /p:MonoAOTEnableLLVM=true /p:MonoBundleLLVMOptimizer=true + # postBuildSteps: + # - template: /eng/pipelines/common/templates/runtimes/build-runtime-tests-and-send-to-helix.yml + # parameters: + # creator: dotnet-bot + # testRunNamePrefixSuffix: Mono_Release + # llvmAotStepContainer: linux_x64_llvmaot + # runtimeVariant: llvmfullaot + # condition: >- + # or( + # eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_libraries.containsChange'], true), + # eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_mono_excluding_wasm.containsChange'], true), + # eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_installer.containsChange'], true), + # eq(variables['isRollingBuild'], true)) From e42239a2993370c1e77b4c2b65e7b3c6e2109270 Mon Sep 17 00:00:00 2001 From: Matous Kozak Date: Mon, 25 Mar 2024 09:25:52 +0100 Subject: [PATCH 03/10] [windows] Disable failing tests Disable System.IO.Tests.MemoryStreamTests.MemoryStream_SeekOverflow_Throws on Mono Windows due to OOM issue --- .../tests/System.IO.Tests/MemoryStream/MemoryStreamTests.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libraries/System.Runtime/tests/System.IO.Tests/MemoryStream/MemoryStreamTests.cs b/src/libraries/System.Runtime/tests/System.IO.Tests/MemoryStream/MemoryStreamTests.cs index 1e7eb491a3699..c88b27033e09d 100644 --- a/src/libraries/System.Runtime/tests/System.IO.Tests/MemoryStream/MemoryStreamTests.cs +++ b/src/libraries/System.Runtime/tests/System.IO.Tests/MemoryStream/MemoryStreamTests.cs @@ -103,6 +103,7 @@ from bufferContext in [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.Is64BitProcess))] [MemberData(nameof(MemoryStream_PositionOverflow_Throws_MemberData))] [SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "https://github.com/dotnet/runtime/issues/92467")] + [ActiveIssue("https://github.com/dotnet/runtime/issues/100225", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime) nameof(PlatformDetection.IsWindows), nameof(PlatformDetection.IsX64Process))] public void MemoryStream_SeekOverflow_Throws(SeekMode mode, int bufferSize, int origin) { byte[] buffer = new byte[bufferSize]; From e0f9279fe2047e1471da7fd35d066927b6654c10 Mon Sep 17 00:00:00 2001 From: Matous Kozak Date: Mon, 25 Mar 2024 09:59:01 +0100 Subject: [PATCH 04/10] [NAOT] disable TrimmingBehaviors smoke tests --- src/tests/issues.targets | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/tests/issues.targets b/src/tests/issues.targets index 4c668a7442dba..771f9da740c09 100644 --- a/src/tests/issues.targets +++ b/src/tests/issues.targets @@ -3127,6 +3127,12 @@ + + + + https://github.com/dotnet/runtime/issues/100226 + + System.Diagnostics.Process is not supported From 041ce2cc2a003b8c9c97fe2a4bcd60a8c5732325 Mon Sep 17 00:00:00 2001 From: Matous Kozak Date: Mon, 25 Mar 2024 10:11:21 +0100 Subject: [PATCH 05/10] disable runtime pipeline --- eng/pipelines/runtime.yml | 35 ++++++++++++++++++----------------- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/eng/pipelines/runtime.yml b/eng/pipelines/runtime.yml index 3cce0b5a17499..13504c845ab7e 100644 --- a/eng/pipelines/runtime.yml +++ b/eng/pipelines/runtime.yml @@ -33,23 +33,24 @@ schedules: - main always: false # run only if there were changes since the last successful scheduled run. -pr: - branches: - include: - - main - - release/*.* - paths: - include: - - '*' - exclude: - - '**.md' - - eng/Version.Details.xml - - .devcontainer/* - - .github/* - - docs/* - - LICENSE.TXT - - PATENTS.TXT - - THIRD-PARTY-NOTICES.TXT +pr: none +# pr: +# branches: +# include: +# - main +# - release/*.* +# paths: +# include: +# - '*' +# exclude: +# - '**.md' +# - eng/Version.Details.xml +# - .devcontainer/* +# - .github/* +# - docs/* +# - LICENSE.TXT +# - PATENTS.TXT +# - THIRD-PARTY-NOTICES.TXT variables: - template: /eng/pipelines/common/variables.yml From 3eda87144ec3a6ac29f8420215565806b09f54b7 Mon Sep 17 00:00:00 2001 From: Matous Kozak Date: Mon, 25 Mar 2024 10:38:49 +0100 Subject: [PATCH 06/10] fix missing ItemGroup closure --- src/tests/issues.targets | 1 + 1 file changed, 1 insertion(+) diff --git a/src/tests/issues.targets b/src/tests/issues.targets index 771f9da740c09..8ee2cab2bd0a9 100644 --- a/src/tests/issues.targets +++ b/src/tests/issues.targets @@ -3132,6 +3132,7 @@ https://github.com/dotnet/runtime/issues/100226 + From d353854fe8ed9605a6735a692b198494ff7264ef Mon Sep 17 00:00:00 2001 From: Matous Kozak Date: Mon, 25 Mar 2024 11:59:13 +0100 Subject: [PATCH 07/10] correct exclusions --- .../tests/System.IO.Tests/MemoryStream/MemoryStreamTests.cs | 2 +- src/tests/issues.targets | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/libraries/System.Runtime/tests/System.IO.Tests/MemoryStream/MemoryStreamTests.cs b/src/libraries/System.Runtime/tests/System.IO.Tests/MemoryStream/MemoryStreamTests.cs index c88b27033e09d..baa158060cfc4 100644 --- a/src/libraries/System.Runtime/tests/System.IO.Tests/MemoryStream/MemoryStreamTests.cs +++ b/src/libraries/System.Runtime/tests/System.IO.Tests/MemoryStream/MemoryStreamTests.cs @@ -103,7 +103,7 @@ from bufferContext in [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.Is64BitProcess))] [MemberData(nameof(MemoryStream_PositionOverflow_Throws_MemberData))] [SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "https://github.com/dotnet/runtime/issues/92467")] - [ActiveIssue("https://github.com/dotnet/runtime/issues/100225", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime) nameof(PlatformDetection.IsWindows), nameof(PlatformDetection.IsX64Process))] + [ActiveIssue("https://github.com/dotnet/runtime/issues/100225", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsWindows), nameof(PlatformDetection.IsX64Process))] public void MemoryStream_SeekOverflow_Throws(SeekMode mode, int bufferSize, int origin) { byte[] buffer = new byte[bufferSize]; diff --git a/src/tests/issues.targets b/src/tests/issues.targets index 8ee2cab2bd0a9..e0351885f87fa 100644 --- a/src/tests/issues.targets +++ b/src/tests/issues.targets @@ -3127,8 +3127,8 @@ - - + + https://github.com/dotnet/runtime/issues/100226 From a85882fa8b9aa304e902fe0635216655fb0a9c4e Mon Sep 17 00:00:00 2001 From: Matous Kozak Date: Mon, 25 Mar 2024 17:51:15 +0100 Subject: [PATCH 08/10] Revert "Disable fullAOT-llvm pipelines due to OOM issues" This reverts commit 92ee6ebb4631877639cb155de5d4c7e9a1b28834. --- eng/pipelines/runtime-llvm.yml | 55 +++++++++++++++++----------------- 1 file changed, 27 insertions(+), 28 deletions(-) diff --git a/eng/pipelines/runtime-llvm.yml b/eng/pipelines/runtime-llvm.yml index 9a8ee3a4d15ff..6338116afd410 100644 --- a/eng/pipelines/runtime-llvm.yml +++ b/eng/pipelines/runtime-llvm.yml @@ -174,31 +174,30 @@ extends: eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_installer.containsChange'], true), eq(variables['isRollingBuild'], true)) - # Disabled due to OOM issues https://github.com/dotnet/runtime/issues/90427 - # - template: /eng/pipelines/common/platform-matrix.yml - # parameters: - # jobTemplate: /eng/pipelines/common/global-build-job.yml - # helixQueuesTemplate: /eng/pipelines/coreclr/templates/helix-queues-setup.yml - # buildConfig: release - # runtimeFlavor: mono - # platforms: - # - linux_x64 - # - linux_arm64 - # jobParameters: - # testGroup: innerloop - # nameSuffix: AllSubsets_Mono_LLVMFullAOT_RuntimeTests - # buildArgs: -s mono+clr.iltools+clr.hosts+libs+host+packs -c $(_BuildConfig) -lc ${{ variables.debugOnPrReleaseOnRolling }} - # /p:MonoEnableLLVM=true /p:MonoAOTEnableLLVM=true /p:MonoBundleLLVMOptimizer=true - # postBuildSteps: - # - template: /eng/pipelines/common/templates/runtimes/build-runtime-tests-and-send-to-helix.yml - # parameters: - # creator: dotnet-bot - # testRunNamePrefixSuffix: Mono_Release - # llvmAotStepContainer: linux_x64_llvmaot - # runtimeVariant: llvmfullaot - # condition: >- - # or( - # eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_libraries.containsChange'], true), - # eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_mono_excluding_wasm.containsChange'], true), - # eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_installer.containsChange'], true), - # eq(variables['isRollingBuild'], true)) + - template: /eng/pipelines/common/platform-matrix.yml + parameters: + jobTemplate: /eng/pipelines/common/global-build-job.yml + helixQueuesTemplate: /eng/pipelines/coreclr/templates/helix-queues-setup.yml + buildConfig: release + runtimeFlavor: mono + platforms: + - linux_x64 + - linux_arm64 + jobParameters: + testGroup: innerloop + nameSuffix: AllSubsets_Mono_LLVMFullAOT_RuntimeTests + buildArgs: -s mono+clr.iltools+clr.hosts+libs+host+packs -c $(_BuildConfig) -lc ${{ variables.debugOnPrReleaseOnRolling }} + /p:MonoEnableLLVM=true /p:MonoAOTEnableLLVM=true /p:MonoBundleLLVMOptimizer=true + postBuildSteps: + - template: /eng/pipelines/common/templates/runtimes/build-runtime-tests-and-send-to-helix.yml + parameters: + creator: dotnet-bot + testRunNamePrefixSuffix: Mono_Release + llvmAotStepContainer: linux_x64_llvmaot + runtimeVariant: llvmfullaot + condition: >- + or( + eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_libraries.containsChange'], true), + eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_mono_excluding_wasm.containsChange'], true), + eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_installer.containsChange'], true), + eq(variables['isRollingBuild'], true)) From 54365fe46610a45c6a9075d5fc2bc9ebc1674a64 Mon Sep 17 00:00:00 2001 From: Matous Kozak Date: Mon, 25 Mar 2024 17:52:02 +0100 Subject: [PATCH 09/10] Disable fullAOT-llvm extra-platform lines (OOM) --- .../runtime-extra-platforms-other.yml | 69 ++++++++++--------- 1 file changed, 35 insertions(+), 34 deletions(-) diff --git a/eng/pipelines/extra-platforms/runtime-extra-platforms-other.yml b/eng/pipelines/extra-platforms/runtime-extra-platforms-other.yml index 97b862d23843a..6728a4ebb4100 100644 --- a/eng/pipelines/extra-platforms/runtime-extra-platforms-other.yml +++ b/eng/pipelines/extra-platforms/runtime-extra-platforms-other.yml @@ -112,41 +112,42 @@ jobs: # Mono CoreCLR runtime Test executions using live libraries and LLVM Full AOT # Only when Mono is changed # -- template: /eng/pipelines/common/platform-matrix.yml - parameters: - jobTemplate: /eng/pipelines/common/global-build-job.yml - helixQueuesTemplate: /eng/pipelines/coreclr/templates/helix-queues-setup.yml - buildConfig: Release - runtimeFlavor: mono - platforms: - - linux_x64 - - linux_arm64 - variables: - - name: timeoutPerTestInMinutes - value: 60 - - name: timeoutPerTestCollectionInMinutes - value: 180 - jobParameters: - testGroup: innerloop - nameSuffix: AllSubsets_Mono_LLVMFullAot_RuntimeTests - runtimeVariant: llvmfullaot - buildArgs: -s mono+libs+clr.hosts+clr.iltools -c Release /p:MonoEnableLLVM=true /p:MonoBundleLLVMOptimizer=true - timeoutInMinutes: 300 - isExtraPlatformsBuild: ${{ parameters.isExtraPlatformsBuild }} +# Disabled due to OOM issues https://github.com/dotnet/runtime/issues/90427 +# - template: /eng/pipelines/common/platform-matrix.yml +# parameters: +# jobTemplate: /eng/pipelines/common/global-build-job.yml +# helixQueuesTemplate: /eng/pipelines/coreclr/templates/helix-queues-setup.yml +# buildConfig: Release +# runtimeFlavor: mono +# platforms: +# - linux_x64 +# - linux_arm64 +# variables: +# - name: timeoutPerTestInMinutes +# value: 60 +# - name: timeoutPerTestCollectionInMinutes +# value: 180 +# jobParameters: +# testGroup: innerloop +# nameSuffix: AllSubsets_Mono_LLVMFullAot_RuntimeTests +# runtimeVariant: llvmfullaot +# buildArgs: -s mono+libs+clr.hosts+clr.iltools -c Release /p:MonoEnableLLVM=true /p:MonoBundleLLVMOptimizer=true +# timeoutInMinutes: 300 +# isExtraPlatformsBuild: ${{ parameters.isExtraPlatformsBuild }} - condition: >- - or( - eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_mono_excluding_wasm.containsChange'], true), - eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_runtimetests.containsChange'], true), - eq(variables['isRollingBuild'], true)) - postBuildSteps: - - template: /eng/pipelines/common/templates/runtimes/build-runtime-tests-and-send-to-helix.yml - parameters: - creator: dotnet-bot - llvmAotStepContainer: linux_x64_llvmaot - testRunNamePrefixSuffix: Mono_Release - extraVariablesTemplates: - - template: /eng/pipelines/common/templates/runtimes/test-variables.yml +# condition: >- +# or( +# eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_mono_excluding_wasm.containsChange'], true), +# eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_runtimetests.containsChange'], true), +# eq(variables['isRollingBuild'], true)) +# postBuildSteps: +# - template: /eng/pipelines/common/templates/runtimes/build-runtime-tests-and-send-to-helix.yml +# parameters: +# creator: dotnet-bot +# llvmAotStepContainer: linux_x64_llvmaot +# testRunNamePrefixSuffix: Mono_Release +# extraVariablesTemplates: +# - template: /eng/pipelines/common/templates/runtimes/test-variables.yml # # Mono CoreCLR runtime Test executions using live libraries in interpreter mode From fe82b9f32094b40da43bc3e9fd6313e9d0ce505b Mon Sep 17 00:00:00 2001 From: Matous Kozak Date: Tue, 26 Mar 2024 12:23:39 +0100 Subject: [PATCH 10/10] Revert "disable runtime pipeline" This reverts commit 041ce2cc2a003b8c9c97fe2a4bcd60a8c5732325. --- eng/pipelines/runtime.yml | 35 +++++++++++++++++------------------ 1 file changed, 17 insertions(+), 18 deletions(-) diff --git a/eng/pipelines/runtime.yml b/eng/pipelines/runtime.yml index 13504c845ab7e..3cce0b5a17499 100644 --- a/eng/pipelines/runtime.yml +++ b/eng/pipelines/runtime.yml @@ -33,24 +33,23 @@ schedules: - main always: false # run only if there were changes since the last successful scheduled run. -pr: none -# pr: -# branches: -# include: -# - main -# - release/*.* -# paths: -# include: -# - '*' -# exclude: -# - '**.md' -# - eng/Version.Details.xml -# - .devcontainer/* -# - .github/* -# - docs/* -# - LICENSE.TXT -# - PATENTS.TXT -# - THIRD-PARTY-NOTICES.TXT +pr: + branches: + include: + - main + - release/*.* + paths: + include: + - '*' + exclude: + - '**.md' + - eng/Version.Details.xml + - .devcontainer/* + - .github/* + - docs/* + - LICENSE.TXT + - PATENTS.TXT + - THIRD-PARTY-NOTICES.TXT variables: - template: /eng/pipelines/common/variables.yml