-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Read messages from binlog if process output is missing build finished message #107280
[wasm] Read messages from binlog if process output is missing build finished message #107280
Conversation
…osoftNetCoreAppRuntimePackDir
/azp run runtime |
Pull request contains merge conflicts. |
This trick with replacing text process output by messages from binlog works https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-107280-merge-d302933e6fae4921a6/Workloads-NoWebcil-ST-Wasm.Build.Tests.TestAppScenarios.SatelliteLoadingTests/1/console.e29afe23.log?helixlogtype=result |
Tagging subscribers to this area: @directhex, @matouskozak |
What are these failures? They do not look connected with the change but I cannot find an active issue. And there's a lot of them
|
I think it's connected. Probably the build fails there with a different message than I'm expecting... |
outputBuilder.AppendLine(m.Title); | ||
}); | ||
|
||
res = new CommandResult(res.StartInfo, res.ExitCode, outputBuilder.ToString()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't you overwrite the output that is normally returned by this method? We are failing in
Assert.Contains("following workloads must be installed: wasm-tools", result.Output); |
so it looks like it's looking for a line that should be there but is not. Can't we append to the existing output when we get res
? And merge that res.Output
with the previous values from line 174?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally it would mean that get the output doubled, which might be... weird. My goal (atm) is to override the output only when the process output is incomplete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fine now
Mitigates #106160