Skip to content

[wasm][interp] Add Store intrinsics #114711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2025
Merged

[wasm][interp] Add Store intrinsics #114711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7358b1f
Add alias for SN SquareRoot as well
lewing Apr 15, 2025
ae7ce8c
Add store alias
lewing Apr 15, 2025
1c97f86
Add Store intrinsics
lewing Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/System.Runtime.Intrinsics/tests/Wasm/PackedSimdTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using System.Numerics;
using System.Runtime.Intrinsics;
using System.Runtime.Intrinsics.Wasm;
Expand Down
3 changes: 3 additions & 0 deletions src/mono/mono/mini/interp/simd-methods.def
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,9 @@ SIMD_METHOD(ShiftLeft)
SIMD_METHOD(ShiftRightArithmetic)
SIMD_METHOD(ShiftRightLogical)
SIMD_METHOD(Shuffle)
SIMD_METHOD(Store)
SIMD_METHOD(StoreUnsafe)
SIMD_METHOD(SquareRoot)
SIMD_METHOD(Sqrt)
SIMD_METHOD(Truncate)
SIMD_METHOD(WidenLower)
Expand Down
14 changes: 13 additions & 1 deletion src/mono/mono/mini/interp/transform-simd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,11 @@ static guint16 packedsimd_alias_methods [] = {
SN_ShiftLeft,
SN_ShiftRightArithmetic,
SN_ShiftRightLogical,
SN_Store,
SN_StoreUnsafe,
SN_Subtract,
SN_Sqrt,
SN_SquareRoot,
SN_Truncate,
SN_WidenLower,
SN_WidenUpper,
Expand Down Expand Up @@ -1243,6 +1246,16 @@ emit_sri_packedsimd (TransformData *td, MonoMethod *cmethod, MonoMethodSignature
return FALSE;
cmethod_name = cmethod->name;
break;
case SN_Sqrt:
case SN_SquareRoot:
cmethod_name = "Sqrt";
break;
case SN_Store:
case SN_StoreUnsafe:
if (csignature->param_count != 2)
return FALSE;
cmethod_name = "Store";
break;
case SN_Add:
case SN_AndNot:
case SN_Subtract:
Expand All @@ -1253,7 +1266,6 @@ emit_sri_packedsimd (TransformData *td, MonoMethod *cmethod, MonoMethodSignature
case SN_Negate:
case SN_Min:
case SN_Max:
case SN_Sqrt:
case SN_Xor:
case SN_Truncate:
cmethod_name = cmethod->name;
Expand Down
Loading