Skip to content

[release/10.0] [mono][aot] Avoid use of local buffer that could overflow #119202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffschwMSFT merged 1 commit into from
Sep 4, 2025
Merged

[release/10.0] [mono][aot] Avoid use of local buffer that could overflow #119202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions src/mono/mono/mini/aot-compiler.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11985,14 +11985,10 @@ emit_got_info (MonoAotCompile *acfg, gboolean llvm)
static void
emit_got (MonoAotCompile *acfg)
{
char symbol [MAX_SYMBOL_SIZE];

if (acfg->aot_opts.llvm_only)
return;

/* Don't make GOT global so accesses to it don't need relocations */
sprintf (symbol, "%s", acfg->got_symbol);

#ifdef TARGET_MACH
emit_unset_mode (acfg);
fprintf (acfg->fp, ".section __DATA, __bss\n");
Expand All @@ -12004,16 +12000,15 @@ emit_got (MonoAotCompile *acfg)
emit_section_change (acfg, ".bss", 0);
emit_alignment (acfg, 8);
if (acfg->aot_opts.write_symbols)
emit_local_symbol (acfg, symbol, "got_end", FALSE);
emit_label (acfg, symbol);
emit_local_symbol (acfg, acfg->got_symbol, "got_end", FALSE);
emit_label (acfg, acfg->got_symbol);
if (acfg->llvm)
emit_info_symbol (acfg, "jit_got", FALSE);
if (acfg->got_offset > 0)
emit_zero_bytes (acfg, (int)(acfg->got_offset * sizeof (target_mgreg_t)));
#endif

sprintf (symbol, "got_end");
emit_label (acfg, symbol);
emit_label (acfg, "got_end");
}

typedef struct GlobalsTableEntry {
Expand Down
Loading