diff --git a/src/mono/wasm/Wasm.Build.Tests/NativeRebuildTests/FlagsChangeRebuildTest.cs b/src/mono/wasm/Wasm.Build.Tests/NativeRebuildTests/FlagsChangeRebuildTest.cs index d8d4cb039497b0..4d34b075949dc1 100644 --- a/src/mono/wasm/Wasm.Build.Tests/NativeRebuildTests/FlagsChangeRebuildTest.cs +++ b/src/mono/wasm/Wasm.Build.Tests/NativeRebuildTests/FlagsChangeRebuildTest.cs @@ -35,13 +35,10 @@ public async Task ExtraEmccFlagsSetButNoRealChange(Configuration config, bool ao ProjectInfo info = CopyTestAsset(config, aot, TestAsset.WasmBasicTestApp, "rebuild_flags"); BuildPaths paths = await FirstNativeBuildAndRun(info, config, aot, requestNativeRelink: true, invariant: false); var pathsDict = GetFilesTable(info.ProjectName, aot, paths, unchanged: true); - bool dotnetNativeFilesUnchanged = extraLDFlags.Length == 0 && extraCFlags.Length == 0; + bool dotnetNativeFilesUnchanged = extraLDFlags.Length == 0; if (!dotnetNativeFilesUnchanged) pathsDict.UpdateTo(unchanged: false, "dotnet.native.wasm", "dotnet.native.js"); - if (extraCFlags.Length != 0) - pathsDict.UpdateTo(unchanged: false, "driver.o", "runtime.o", "corebindings.o", "pinvoke.o"); - var originalStat = StatFiles(pathsDict); // Rebuild @@ -56,9 +53,8 @@ public async Task ExtraEmccFlagsSetButNoRealChange(Configuration config, bool ao // and thus doesn't cause relinking TestUtils.AssertSubstring("pinvoke.c -> pinvoke.o", output, contains: extraCFlags.Length > 0); - // ldflags or cflags: link step args change, so it should trigger relink + // ldflags: link step args change, so it should trigger relink TestUtils.AssertSubstring("Linking with emcc", output, contains: !dotnetNativeFilesUnchanged); - if (aot) { // ExtraEmccLDFlags does not affect .bc files diff --git a/src/mono/wasm/Wasm.Build.Tests/WasmNativeDefaultsTests.cs b/src/mono/wasm/Wasm.Build.Tests/WasmNativeDefaultsTests.cs index 9c1a4e8c0beddb..22bf394ec2a4c4 100644 --- a/src/mono/wasm/Wasm.Build.Tests/WasmNativeDefaultsTests.cs +++ b/src/mono/wasm/Wasm.Build.Tests/WasmNativeDefaultsTests.cs @@ -144,7 +144,7 @@ public void WasmNativeStripDefaultWithBuild(Configuration config, string extraPr CheckPropertyValues(line, wasmBuildNative: expectedWasmBuildNativeValue, wasmNativeStrip: expectedWasmNativeStripValue, - wasmNativeDebugSymbols: config == Configuration.Debug && !expectedWasmNativeStripValue, + wasmNativeDebugSymbols: true, wasmBuildingForNestedPublish: null); } @@ -158,7 +158,7 @@ public void WasmNativeStripDefaultWithPublish(Configuration config, string extra CheckPropertyValues(line, wasmBuildNative: expectedWasmBuildNativeValue, wasmNativeStrip: expectedWasmNativeStripValue, - wasmNativeDebugSymbols: false, + wasmNativeDebugSymbols: true, wasmBuildingForNestedPublish: true); } @@ -233,7 +233,7 @@ private void InferAndCheckPropertyValues(string? line, bool isPublish, bool wasm } else { - expectedWasmNativeDebugSymbols = false; + expectedWasmNativeDebugSymbols = true; expectedWasmNativeStripValue = true; } diff --git a/src/mono/wasm/build/WasmApp.Common.targets b/src/mono/wasm/build/WasmApp.Common.targets index d9bf8e3b931dae..7b21df5f3a12fd 100644 --- a/src/mono/wasm/build/WasmApp.Common.targets +++ b/src/mono/wasm/build/WasmApp.Common.targets @@ -537,7 +537,7 @@ - false + true true @@ -911,8 +911,8 @@ - - +