Expand test coverage for native AOT on android #121217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

sbomer wants to merge 49 commits into main from sbomer/naot-android-coverage

Member

sbomer commented Oct 30, 2025 •

edited

Loading

Enables building native AOT smoke tests for android with one APK per test project
Adds marker files to set expected exit code when running through helix
Adds a runtime-androidemulator job for native AOT smoke tests
Expands libraries test coverage to include non-smoke tests
Sets up appcontext base directory in test host
Calls managed main through a pinvoke when running Exe project in the runtime tests

sbomer added 30 commits

October 13, 2025 17:21


          Add more native AOT on android ci test coverage

3bf76d6

- Expand native AOT smoke tests to all libraries tests - Add job for
runtime smoke tests using native AOT on emulator


          Remove --cross argument, fix and disable some libs tests

432572c


          Remove --cross argument, fix and disable some libs tests

214d1f9


          Set runtimeFlavor to coreclr

a9eeff0


          Parameterize runtimeFlavor in Android job definitions

5253ab2


          Remove runtimeFlavor: coreclr from Android emulator pipeline

9d8577b


          Fix typo in runtimeFlavor parameter name

fef0415


          Add 'nativeaot' arg to testBuildArgs for Android emulator

c509f51


          Increase timeout to 180

4cbbff5


          Refactor Android NDK compiler selection for test builds

c1292f1

Move NDK compiler logic to a shared props file and import it in test and
build projects to unify Android NativeAOT and Mono builds.


          Increase timeout to 240

dfbf8ea


          Pass RuntimeFlavor to AndroidAppBuilderTask

b8abeba


          Check TestBuildMode instead

cc1d5c3


          Fix a few test failures

2b7f252

- Set ASSETS_DIR for crypto tests
  (using same pattern as existing crypto test)
- Set AppContext.BaseDirectory

We should probably change crypto tests to use
just AppContext.BaseDirectory.


          Set Environment.CurrentDirectory to app files directory

1ee5f13


          Exclude tests failing due to missing calli marshalling support

cce4d9a


          Exclude tests failing due to missing crypto shim export

e6338fb


          Enable building smoke tests as apks

5c723f5

- Use ReferenceXUnitWrapperGenerator != false to define SINGLE_FILE_TEST_RUNNER (android & singlefile targets) instead of IsFunctionalTest
- Condition SingleFileTestRunner compile and TrimmerRootAssembly (TestUtilities) on wrapper/generator and SkipTestUtilitiesReference
- Add Android NativeAOT publish/trim settings and set NativeLib/CustomNativeMain for android nativeaot
- Make DisableImplicitFrameworkReferences respect preexisting value and add explicit DisableImplicitFrameworkReferences=false in nativeaot tests dir
- Import testing\tests.targets when TargetsAndroid is true
- Update many NativeAOT smoke tests Main signatures to public static int Main(string[] args) to match runner invocation


          Fix smoke test build for android

d0d7bc3

- Ensure they have Main entry point
- Tighten MSBuild conditions:
  - Only set NativeLib/CustomNativeMain for Android when OutputType == Exe
  - Only import testing/tests.targets for Android when using MicrosoftNETSdk and building executables
  - Make TestNativeAOT/UseNativeAOTRuntime defaults apply when TestBuildMode == nativeaot and only include monodroid-nativeaot.cs for executable/XUnit-wrapper cases


          Disable directory apk build for smoke tests

eec6deb


          Try using merged test runners

4ed06ec


          Revert "Try using merged test runners"

cbcca7d

This reverts commit 4ed06ec.


          Add Merged marker for smoke tests

37b7b4e


          Try merged wrappers again

9e89dda

- Avoid importing logic for SharedLibrary
- Fix library filename
- Set HasMergedInTests to ensure projects build


          Revert "Add Merged marker for smoke tests"

3a266b8

This reverts commit 37b7b4e.


          Fix some issues with non-standalone build

a0c0cd6


          Remove buildAllTestsAsStandalone

55b18f5


          Set expected exit code

8e60575


          Remove redundant import

9f6e630

This import is now covered by the IsMergedTestRunnerAssembly property.
Fixes a warning about a double import.
Fixes issue where mono runtime tests are getting incorrect assembly name
due to this undesired import.


          Fix mono test build

d4d4ad3

dotnet deleted a comment from azure-pipelines bot

This was referenced Nov 5, 2025

[wasm] OpenQA.Selenium.WebDriverTimeoutException: timeout: Timed out receiving message from renderer #117486

Open

[wasm/browser] Failed to connect to socket /run/dbus/system_bus_socket #120176

Open

System.Security.Cryptography.X509Certificates.Tests fails on Linux #120527

Open

sbomer added 2 commits

November 5, 2025 16:42


          Try to fix condition for SingleFileTestRunner, fix test failure

61e4a37


          Move shared props out of nativeaot dir

216417e

And fix resulting duplicate imports
due to build.proj getting these settings.

Member Author

sbomer commented Nov 6, 2025

/azp run runtime-androidemulator

Member Author

sbomer commented Nov 6, 2025

/azp run runtime-android

azure-pipelines bot commented Nov 6, 2025

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment

azure-pipelines bot commented Nov 6, 2025

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Nov 6, 2025

ProcessThreadTests.TestStartTimeProperty failure in CI #105526

Open

error : HttpRequestException: The SSL connection could not be established, see inner exception. dotnet/dnceng#5015

Open

Android System.Security.Cryptography test failure: Signing key verifies the CRL #119023

Open

[wasm] Microsoft.Playwright.TargetClosedException : Target page, context or browser has been closed #121195

Open

[android-arm64] The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#6408

Open

Certificate issues when Sending To Helix from Apple platforms dotnet/dnceng#6410

Open

Member Author

sbomer commented Nov 10, 2025

/azp run runtime-androidemulator

Member Author

sbomer commented Nov 10, 2025

/azp run runtime-android

azure-pipelines bot commented Nov 10, 2025

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment

azure-pipelines bot commented Nov 10, 2025

Azure Pipelines successfully started running 1 pipeline(s).

sbomer force-pushed the sbomer/naot-android-coverage branch 2 times, most recently from 86c577c to c3b24c9 Compare

November 10, 2025 21:00

sbomer added 3 commits

November 10, 2025 13:00


          Fix build error, disable test, and try to clean up condition

c7a781e


          Adjust condition

8421ca3


          Disable ThreadTest

c3b24c9

Member Author

sbomer commented Nov 10, 2025

/azp run runtime-androidemulator

Member Author

sbomer commented Nov 10, 2025

/azp run runtime-android

azure-pipelines bot commented Nov 10, 2025

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment

azure-pipelines bot commented Nov 10, 2025

Azure Pipelines successfully started running 1 pipeline(s).

build-analysis bot mentioned this pull request

Known Test Repository Issue Sometimes Misses Test Failures dotnet/dnceng#6411

Open

3 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jkotas jkotas left review comments

MichalStrehovsky MichalStrehovsky left review comments

Copilot code review Copilot Copilot left review comments

steveisok Awaiting requested review from steveisok steveisok is a code owner

vitek-karas Awaiting requested review from vitek-karas vitek-karas is a code owner

At least 1 approving review is required to merge this pull request.

Labels

area-NativeAOT-coreclr