Look up the correct MethodTable on COM methods.
#121431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tagging subscribers to this area: @dotnet/interop-contrib |
This was referenced Nov 7, 2025
Open
AaronRobinsonMSFT
force-pushed
the
runtime_121252
branch
from
a791edf to
01c1e2a
Compare
AaronRobinsonMSFT
requested review from
Copilot,
elinor-fung and
jkoritzinsky
jkoritzinsky
approved these changes
Nov 10, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors COM interop code in two key ways: simplifying COM object instantiation in tests and improving the implementation of exception handling for COM HRESULTs.
- Removes redundant explicit casts when instantiating COM objects via the CoClass pattern
- Adds diagnostic logging to test execution with
Console.WriteLine(nameof(...)) - Refactors
GetCOMHRExceptionObjectto use a new direct native helper method instead of theRuntimeMethodHandle.FromIntPtrpathway
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/tests/Interop/COM/NETClients/Primitives/StringTests.cs | Removed redundant cast in COM object instantiation and added diagnostic logging |
| src/tests/Interop/COM/NETClients/Primitives/NumericTests.cs | Removed redundant cast in COM object instantiation and added diagnostic logging |
| src/tests/Interop/COM/NETClients/Primitives/ErrorTests.cs | Removed redundant cast in COM object instantiation and added diagnostic logging |
| src/tests/Interop/COM/NETClients/Primitives/ColorTests.cs | Removed redundant cast in COM object instantiation and added diagnostic logging |
| src/tests/Interop/COM/NETClients/Primitives/CallViaReflectionTests.cs | Removed redundant cast in COM object instantiation |
| src/tests/Interop/COM/NETClients/Primitives/ArrayTests.cs | Removed redundant cast in COM object instantiation and added diagnostic logging |
| src/tests/Interop/COM/NETClients/MiscTypes/Program.cs | Removed redundant casts in COM object instantiation |
| src/tests/Interop/COM/NETClients/Licensing/Program.cs | Removed redundant casts in COM object instantiation |
| src/tests/Interop/COM/NETClients/IInspectable/Program.cs | Removed redundant cast in COM object instantiation |
| src/tests/Interop/COM/NETClients/IDispatch/Program.cs | Removed redundant casts in COM object instantiation |
| src/tests/Interop/COM/NETClients/Events/Program.cs | Removed redundant casts in COM object instantiation |
| src/tests/Interop/COM/NETClients/ComDisabled/Program.cs | Removed redundant cast in COM object instantiation |
| src/coreclr/vm/stubhelpers.h | Added declaration for new helper method GetComInterfaceFromMethodDesc |
| src/coreclr/vm/stubhelpers.cpp | Implemented new helper method to extract interface MethodTable from a method descriptor |
| src/coreclr/vm/ecalllist.h | Registered the new helper method as an FCFunc |
| src/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs | Refactored GetCOMHRExceptionObject to use new direct native helper instead of RuntimeMethodHandle pathway |
elinor-fung
approved these changes
Nov 10, 2025
Member
Author
|
/ba-g Unrelated timeouts |
3 tasks
Member
Author
|
/backport to release/10.0 |
Contributor
|
Started backporting to |
4 tasks
steveisok
pushed a commit
that referenced
this pull request
Nov 11, 2025
…1512) Backport of #121431 to release/10.0 /cc @AaronRobinsonMSFT ## Customer Impact - [x] Customer reported - [ ] Found internally How a COM server is activated can obscure how we determine the `IID` of a COM interface method. This matters in scenarios involving `ISupportErrorInfo`. A user reported this in #121252. ## Regression - [x] Yes - [ ] No This is a regression from .NET 9. It was introduced in #117690. ## Testing Tests were updated to validate this behavior. ## Risk Low. This only impacts COM scenarios involving `ISupportErrorInfo`. --------- Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121252
Update tests to activate correctly.