Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable EventLog test on all targets #32403

Merged
merged 1 commit into from
Feb 16, 2020
Merged

Conversation

ViktorHofer
Copy link
Member

Disabling to get CI green: #32241

cc @stephentoub @danmosemsft @safern

Disabling to get CI green: #32241
@ViktorHofer
Copy link
Member Author

Failure is #32300

@ViktorHofer ViktorHofer merged commit 15f2048 into master Feb 16, 2020
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-1 branch February 16, 2020 19:22
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danmoseley
Copy link
Member

I believe we've seen this same error on other Event Log tests - and apparently retries aren't a reliable workaround. I wonder whether we need an attribute for a category of tests that we cannot make more than 99.9% reliable and (unlike networking tests perhaps) we also believe we are very unlikely to break. Such tests we would run manually before releases.

@ViktorHofer
Copy link
Member Author

That sounds like a better approach going forward. Other tests already failed again: https://dnceng.visualstudio.com/public/_build/results?buildId=525306&view=ms.vss-test-web.build-test-results-tab&runId=16620540&resultId=180692&paneView=debug.

So I would disable all EventLog tests on CI by attributing them with a custom trait (we already have one called IgnoreForCI).

@danmoseley
Copy link
Member

Let's do that.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants