Suppress linker analysis warnings on GetImmutableDictionaryCreateRangeMethod #42905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
approved these changes
Sep 30, 2020
ViktorHofer
approved these changes
Sep 30, 2020
steveharter
approved these changes
Sep 30, 2020
There was a problem hiding this comment.
LGTM; currently affecting CI in https://github.com/dotnet/runtime/pull/42538/checks?check_run_id=1188656484
|
Merging to unblock CI. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42902.
These changes need to be made following #42835 which added a new parameter to the method. That PR was merged before the baseline suppressions were checked in. In the future, the linker warnings would be caught in CI or locally if the
libssubset is rebuilt.