Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate RID and native file naming in MSBuild scripts #43804

Merged
3 commits merged into from
Nov 19, 2020
Merged

Consolidate RID and native file naming in MSBuild scripts #43804

3 commits merged into from
Nov 19, 2020

Commits on Nov 19, 2020

  1. Consolidate RID and native file naming in MSBuild scripts 

    * Use short variable names for native files naming convention, that are
  used by `framework.sharedfx.targets` in arcade, and cleanup
  redefinitions from crossgen2 and installer. e.g. `ExeSuffix` instead
  of `ApplicationFileExtension`, `LibSuffix` instead of
  `LibraryFileExtension` and so on.
* Calculate `TargetArchitecture`, `NonPortableRuntimeOS` (for
  `PortableBuild`) and `PackageRID` values once for the entire
  livebuild, inside `eng/Configurations.props`. This implementation is
  a union of three varied implementations that are being deleted.
* Import `names.props` once in `eng/Configurations.props` based on
  calculated `PackageRID` and cleanup imports of this file from various
  places.
* Combine OS targets definition in MSBuild scripts.
    @am11
    am11 committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    534c299 View commit details
    Browse the repository at this point in the history

  2. Delete legacy tooling properties

    @am11
    am11 committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    ee9471a View commit details
    Browse the repository at this point in the history

  3. Delete legacy tooling properties

    @am11
    am11 committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    311fabe View commit details
    Browse the repository at this point in the history