TcpClient.ConnectAsync(EndPoint) #44110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/ncl |
|
|
stephentoub
added
area-System.Net.Sockets
and removed
area-Extensions-HttpClientFactory
labels
|
Tagging subscribers to this area: @dotnet/ncl |
stephentoub
reviewed
Nov 1, 2020
stephentoub
reviewed
Nov 1, 2020
stephentoub
reviewed
Nov 1, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
geoffkizer
reviewed
Nov 2, 2020
|
We really should have cancellation tests for the cancellation overloads, but since we don't today it's fine to skip them. Since it's literally just a pass-through to Socket it's not a big deal. |
|
Thanks @MartyIX! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tentative attempt to fix #43111.
I'm not familiar with this code so it may be totally off. I'm not sure. Feedback is welcome. Or if somebody wants to finish the job, I'm not against.
Friendly ping @karelz @geoffkizer