Fix SAPI error code mappings #46841

danmoseley · 2021-01-12T01:40:27Z

Fixes #46801

Resource messages for SAPI error codes are looked up by index. I had broken this mapping because I didn't realize that whoever defined the SAPI error codes seemingly accidentally jumped from hex to decimal in two places and missed two blocks of 6 codes. Fixed this and added error messages for some SAPI codes that were never included (at the end - seemingly a mistake) and added a bunch of comments. As best I can tell, it's now correct.
Disable the SpeechRecognizerTest when the platform doesn't support speech, or it's not initialized, or not installed, or not enabled somehow.

Running CI first with 2nd part disabled so I can verify the error messages are now correct.

danmoseley · 2021-01-12T01:44:59Z

/azp run runtime-libraries-coreclr outerloop-windows

azure-pipelines · 2021-01-12T01:45:11Z

Azure Pipelines successfully started running 1 pipeline(s).

danmoseley · 2021-01-12T03:52:18Z

/azp run runtime-libraries-coreclr outerloop-windows

azure-pipelines · 2021-01-12T03:52:31Z

Azure Pipelines successfully started running 1 pipeline(s).

danmoseley · 2021-01-12T03:54:12Z

/azp run runtime-libraries-mono outerloop

danmoseley · 2021-01-12T03:54:16Z

/azp run runtime-libraries-coreclr outerloop-windows

azure-pipelines · 2021-01-12T03:54:24Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2021-01-12T03:54:30Z

Azure Pipelines successfully started running 1 pipeline(s).

danmoseley · 2021-01-12T05:27:45Z

OK, validated by forcing the tests to fail that the messages are now appropriate:

Windows 81, Windows 7

 System.PlatformNotSupportedException : No recognizer is installed.
      Stack Trace:
        /_/src/libraries/System.Speech/src/Recognition/RecognizerBase.cs(455,0): at System.Speech.Recognition.RecognizerBase.Initialize(SapiRecognizer recognizer, Boolean inproc)

Windows 10 / remote desktop

     System.InvalidOperationException : No audio device is installed.
      Stack Trace:
        /_/src/libraries/System.Speech/src/Recognition/RecognizerBase.cs(455,0): at System.Speech.Recognition.RecognizerBase.Initialize(SapiRecognizer recognizer, Boolean inproc)

Now doing it for real.

danmoseley · 2021-01-12T05:28:00Z

/azp run runtime-libraries-coreclr outerloop-windows

danmoseley · 2021-01-12T05:28:07Z

/azp run runtime-libraries-mono outerloop

azure-pipelines · 2021-01-12T05:28:12Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2021-01-12T05:28:18Z

Azure Pipelines successfully started running 1 pipeline(s).

danmoseley · 2021-01-12T05:28:37Z

once this is merged I need to cherry pick it into #46729

src/libraries/System.Speech/Directory.Build.props

Wraith2 · 2021-01-12T09:40:04Z

whoever defined the SAPI error codes seemingly accidentally jumped from hex to decimal in two places and missed two blocks of 6 codes.

I thought I heard a faint cry of "Why! why would you do that!" somewhere... 😁

src/libraries/System.Speech/src/Resources/Strings.resx

src/libraries/System.Speech/tests/SpeechRecognizerTests.cs

Co-authored-by: Stephen Toub <stoub@microsoft.com>

ghost · 2021-01-12T17:28:01Z

Hello @danmosemsft!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

danmoseley · 2021-01-12T19:38:03Z

Failures are unrelated libraries - I will take a look later.

* Fix PKT * Fix SAPI errors * Disable test as appropriate * enable more tests to fail to get messages * reenable tests * Update src/libraries/System.Speech/tests/SpeechRecognizerTests.cs Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: Stephen Toub <stoub@microsoft.com>

* Port System.Speech to .NET Core (#45941) * Initial sources, with banners * Run the code formatter * Fix hang in XUnit due to failing to complete all AsyncOperation-s * Remove reflection over RegistryKey * Add ref and packaging * Add tests * Add sln * Fix CS1584 * Fix CA1823 * Fix CA1834 * Unnecessary suppressions * Fix SA1028 * Fix CA1507 * Fix CA1810 * Fix CA1825 * Fix CA1825 * Unnecessary suppressions * Fix CA1805 * Fix IDE0004 * Fix IDE0090 * Remove CAS * Remove tabs and dead code * Unnecessary suppressions * Fix SA1212 * Fix SA1121 * Disable SA1129 * Fix SA1206 * Fix SA1518 * Fix SA1617 * Fix SA1001 * Fix CS0618 * Remove unnecessary comments * Remove unnecessary whitespace * Remove low value xml doc comments * Unused usings * dead files * Remove CAS * More junk * Fix obvious original bug * Remove/insert newlines * Remove reference to old design document * Fix spacing * Fix typo name * Fix file casing * Remove dead code * Add to compat pack * Remove AppDomain etc * Fix casing of .NET * Remove low value XML docs * Remove code that relies on compiling assemblies * Fix inadvertently removed padding * Use EDI to preserve stack when rethrowing * Fix misaligned resource ID's to match sperror.h * Skip SpeechRecognitionEngine tests if no installed recognizers * Fix misformatted string bug * Logging for CI error * Fix NRE trying to map phonemes for voice for culture for which we do not have phoneme map * Fix 153 spelling errors in comments using `Visual Studio Spell Checker` * Remove extraneous file * Fix spacing * Fix project reference * Reorder properties in csproj * Change from netcoreapp2.0 to netcoreapp2.1 * Update src/libraries/System.Speech/pkg/System.Speech.pkgproj Co-authored-by: Jose Perez Rodriguez <joperezr@microsoft.com> * Add build error for targeting netcoreapp2.0 * Suppress new error during packaging testing * Update System.Speech.targets * Remove ref comments * Update pkgproj * Remove placeholder Co-authored-by: Jose Perez Rodriguez <joperezr@microsoft.com> Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com> * Fix port * Disable some Speech tests on Server Core * Set PackageVersion in Directory.Build.props * Change packageIndex back to 5.0.0 * Don't rev the platforms package unless we ship it * Fix PKT * Add to libraries-packages.proj * Fix SAPI error code mappings (#46841) * Fix PKT * Fix SAPI errors * Disable test as appropriate * enable more tests to fail to get messages * reenable tests * Update src/libraries/System.Speech/tests/SpeechRecognizerTests.cs Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: Jose Perez Rodriguez <joperezr@microsoft.com> Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com> Co-authored-by: Eric StJohn <ericstj@microsoft.com> Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: Anirudh Agnihotry <anirudhagnihotry098@gmail.com>

Dotnet-GitSync-Bot added the area-Meta label Jan 12, 2021

danmoseley added area-System.Speech and removed area-Meta labels Jan 12, 2021

danmoseley mentioned this pull request Jan 12, 2021

[release/5.0] Backport System.Speech to compat pack #46729

Merged

danmoseley added 5 commits January 11, 2021 21:25

Fix PKT

90f4829

Fix SAPI errors

776327f

Disable test as appropriate

734dc95

enable more tests to fail to get messages

d4d4658

reenable tests

e27468c

danmoseley force-pushed the fix.sapi.errors branch from 142368a to e27468c Compare January 12, 2021 05:27

danmoseley marked this pull request as ready for review January 12, 2021 05:27

danmoseley requested a review from stephentoub January 12, 2021 05:28

danmoseley commented Jan 12, 2021

View reviewed changes

src/libraries/System.Speech/Directory.Build.props Show resolved Hide resolved

stephentoub reviewed Jan 12, 2021

View reviewed changes

src/libraries/System.Speech/src/Resources/Strings.resx Show resolved Hide resolved

stephentoub reviewed Jan 12, 2021

View reviewed changes

src/libraries/System.Speech/tests/SpeechRecognizerTests.cs Outdated Show resolved Hide resolved

stephentoub approved these changes Jan 12, 2021

View reviewed changes

Update src/libraries/System.Speech/tests/SpeechRecognizerTests.cs

3397311

Co-authored-by: Stephen Toub <stoub@microsoft.com>

danmoseley added the auto-merge label Jan 12, 2021

danmoseley merged commit 430c07a into dotnet:master Jan 12, 2021

danmoseley deleted the fix.sapi.errors branch January 12, 2021 19:38

ghost locked as resolved and limited conversation to collaborators Feb 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix SAPI error code mappings #46841

Fix SAPI error code mappings #46841

danmoseley commented Jan 12, 2021 •

edited

Loading

danmoseley commented Jan 12, 2021

azure-pipelines bot commented Jan 12, 2021

danmoseley commented Jan 12, 2021

azure-pipelines bot commented Jan 12, 2021

danmoseley commented Jan 12, 2021

danmoseley commented Jan 12, 2021

azure-pipelines bot commented Jan 12, 2021

azure-pipelines bot commented Jan 12, 2021

danmoseley commented Jan 12, 2021

danmoseley commented Jan 12, 2021

danmoseley commented Jan 12, 2021

azure-pipelines bot commented Jan 12, 2021

azure-pipelines bot commented Jan 12, 2021

danmoseley commented Jan 12, 2021

Wraith2 commented Jan 12, 2021

ghost commented Jan 12, 2021

danmoseley commented Jan 12, 2021

Fix SAPI error code mappings #46841

Fix SAPI error code mappings #46841

Conversation

danmoseley commented Jan 12, 2021 • edited Loading

danmoseley commented Jan 12, 2021

azure-pipelines bot commented Jan 12, 2021

danmoseley commented Jan 12, 2021

azure-pipelines bot commented Jan 12, 2021

danmoseley commented Jan 12, 2021

danmoseley commented Jan 12, 2021

azure-pipelines bot commented Jan 12, 2021

azure-pipelines bot commented Jan 12, 2021

danmoseley commented Jan 12, 2021

danmoseley commented Jan 12, 2021

danmoseley commented Jan 12, 2021

azure-pipelines bot commented Jan 12, 2021

azure-pipelines bot commented Jan 12, 2021

danmoseley commented Jan 12, 2021

Wraith2 commented Jan 12, 2021

ghost commented Jan 12, 2021

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

danmoseley commented Jan 12, 2021

danmoseley commented Jan 12, 2021 •

edited

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.