Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize ReceiveMessageFrom tests and bring them back to Inner Loop #46862

Merged

Conversation

antonfirsov
Copy link
Member

@antonfirsov antonfirsov commented Jan 12, 2021

Contributes to #41502 and #43845 by making the tests for ReceiveMessageFrom easier maintain and extend, harmonizing them under the SocketTestHelper infrastructure similarly to the code in SendReceive.cs

All old ReceiveMessageFrom.cs and ReceiveMessageFromAsync.cs tests have been refactored to ReceiveMessageFrom<T> and subclasses:

All the ReceiveMessageFrom tests are brought back to inner loop, since there's no reason to keep them in outer loop. They were pushed out in dotnet/corefx#11341 as part of an umbrella operation to stabilize networking tests. I'm not aware of any instabilities caused by ReceiveMessageFrom runs.

@ghost
Copy link

ghost commented Jan 12, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #41502 and #43845 by making the tests for ReceiveMessageFrom easier to follow and extend, harmonizing them under the SocketTestHelper infrastructure similarly to the code in SendReceive.cs

All old ReceiveMessageFrom.cs and ReceiveMessageFromAsync.cs tests have been refactored to ReceiveMessageFrom<T> and subclasses:

All the ReceiveMessageFrom tests are brought back to inner loop, since there's no reason to keep them in outer loop. They were pushed out in dotnet/corefx#11341 as part of an umbrella operation to stabilize networking tests. I'm not aware of any instabilities caused by ReceiveMessageFrom runs.

Author: antonfirsov
Assignees: -
Labels:

area-System.Net

Milestone: -

@ghost
Copy link

ghost commented Jan 12, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #41502 and #43845 by making the tests for ReceiveMessageFrom easier maintain and extend, harmonizing them under the SocketTestHelper infrastructure similarly to the code in SendReceive.cs

All old ReceiveMessageFrom.cs and ReceiveMessageFromAsync.cs tests have been refactored to ReceiveMessageFrom<T> and subclasses:

All the ReceiveMessageFrom tests are brought back to inner loop, since there's no reason to keep them in outer loop. They were pushed out in dotnet/corefx#11341 as part of an umbrella operation to stabilize networking tests. I'm not aware of any instabilities caused by ReceiveMessageFrom runs.

Author: antonfirsov
Assignees: -
Labels:

area-System.Net.Sockets

Milestone: -

Copy link
Contributor

@geoffkizer geoffkizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- one minor comment above

@geoffkizer
Copy link
Contributor

This is nice to see, thanks.

@geoffkizer geoffkizer merged commit b95de55 into dotnet:master Jan 13, 2021
@karelz karelz added this to the 6.0.0 milestone Jan 26, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants