-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harmonize ReceiveMessageFrom tests and bring them back to Inner Loop #46862
Harmonize ReceiveMessageFrom tests and bring them back to Inner Loop #46862
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue DetailsContributes to #41502 and #43845 by making the tests for All old
All the
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsContributes to #41502 and #43845 by making the tests for All old
All the
|
src/libraries/System.Net.Sockets/tests/FunctionalTests/ReceiveMessageFrom.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- one minor comment above
This is nice to see, thanks. |
Contributes to #41502 and #43845 by making the tests for
ReceiveMessageFrom
easier maintain and extend, harmonizing them under theSocketTestHelper
infrastructure similarly to the code inSendReceive.cs
All old
ReceiveMessageFrom.cs
andReceiveMessageFromAsync.cs
tests have been refactored toReceiveMessageFrom<T>
and subclasses:ReceiveMessageFrom<T>.ReceiveSentMessages_Success
replace the following old tests:ReceiveMessageFrom.Success
,ReceiveMessageFrom.Success_IPv6
,ReceiveMessageFrom.Success_APM
,ReceiveMessageFromAsync.ReceiveSentMessages_Tasks_Success
ReceiveMessageFrom<T>.ReceiveSentMessages_ReuseEventArgs_Success
serve as a replacement for:ReceiveMessageFrom.Success_EventArgs
,ReceiveMessageFromAsync.ReceiveSentMessages_SocketAsyncEventArgs_Success
. These 2 were more or less duplicates, except that latter served as a regression test for Fix lifetime handling of ReceiveMessageFromAsync buffer on Windows corefx#22012 by setting the buffer multiple times. The new test case keeps exercising this behavior. (Note: I also tried to alter between different buffer modes using the sameSocketAsyncEventArgs
instance, which made me to discover ReceiveMessageFrom does not work correctly on Linux after altering BufferList to a single buffer #46860.)All the
ReceiveMessageFrom
tests are brought back to inner loop, since there's no reason to keep them in outer loop. They were pushed out in dotnet/corefx#11341 as part of an umbrella operation to stabilize networking tests. I'm not aware of any instabilities caused byReceiveMessageFrom
runs.