Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable failing DNS tests on SLES #48759

Merged
merged 2 commits into from
Feb 25, 2021

Conversation

ViktorHofer
Copy link
Member

As there's currently no infrastructure to disable just for SLES,
disabling for its parent, which is Linux.

#48751

cc @dotnet/ncl

As there's currently no infrastructure to disable just for SLES,
disabling for its parent, which is Linux.
@ghost
Copy link

ghost commented Feb 25, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

As there's currently no infrastructure to disable just for SLES,
disabling for its parent, which is Linux.

#48751

cc @dotnet/ncl

Author: ViktorHofer
Assignees: -
Labels:

area-System.Net

Milestone: -

@stephentoub
Copy link
Member

As there's currently no infrastructure to disable just for SLES, disabling for its parent, which is Linux.

We can't add an IsSles like we do for other distros?

private static bool IsLinux => RuntimeInformation.IsOSPlatform(OSPlatform.Linux);
public static bool IsOpenSUSE => IsDistroAndVersion("opensuse");
public static bool IsUbuntu => IsDistroAndVersion("ubuntu");
public static bool IsDebian => IsDistroAndVersion("debian");
public static bool IsAlpine => IsDistroAndVersion("alpine");
public static bool IsDebian8 => IsDistroAndVersion("debian", 8);
public static bool IsDebian10 => IsDistroAndVersion("debian", 10);
public static bool IsUbuntu1604 => IsDistroAndVersion("ubuntu", 16, 4);
public static bool IsUbuntu1704 => IsDistroAndVersion("ubuntu", 17, 4);
public static bool IsUbuntu1710 => IsDistroAndVersion("ubuntu", 17, 10);
public static bool IsUbuntu1710OrHigher => IsDistroAndVersionOrHigher("ubuntu", 17, 10);
public static bool IsUbuntu1804 => IsDistroAndVersion("ubuntu", 18, 04);
public static bool IsUbuntu1810OrHigher => IsDistroAndVersionOrHigher("ubuntu", 18, 10);
public static bool IsTizen => IsDistroAndVersion("tizen");
public static bool IsFedora => IsDistroAndVersion("fedora");

@ViktorHofer
Copy link
Member Author

Feel free to update the PR with your suggestion. I'm on the phone and won't have access to my PC the next few hours.

@ViktorHofer
Copy link
Member Author

With infrastructure I meant the platform detection in XUnitExtensions so that it can be applied to an ActiveIssueAttribute.

@ViktorHofer ViktorHofer requested a review from a team February 25, 2021 17:47
@ViktorHofer
Copy link
Member Author

Can someone please approve? The failures are showing up on every PR that runs these tests (on SLES).

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok for the emergency.
I will follow-up on this separately.

@ViktorHofer ViktorHofer changed the title Disable failing DNS tests on Linux Disable failing DNS tests on SLES Feb 25, 2021
@ViktorHofer ViktorHofer merged commit cbc05c4 into dotnet:master Feb 25, 2021
@ViktorHofer ViktorHofer deleted the DnsFailingTests branch February 25, 2021 22:15
@ghost ghost locked as resolved and limited conversation to collaborators Mar 27, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants