Fix failures on Windows when more warnings are enabled. #49194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsFixes #42767
|
|
@GrabYourPitchforks I've not added the compiler flags from the issues to this PR. I added them locally and compiled across x86/Amd64/ARM/ARM64 and Debug/Release on Windows. Do you have a place in mind where those flags should be added? |
This was referenced Mar 5, 2021
jkotas
reviewed
Mar 5, 2021
Revert usage of _vsnwprintf_s since it has different semantics than _vsnwprintf. Verified _vsnwprintf is being used correctly.
GrabYourPitchforks
approved these changes
Mar 18, 2021
danmoseley
reviewed
Mar 19, 2021
src/libraries/Native/Windows/System.IO.Compression.Native/zlib-intel/inflate.c
Show resolved
Hide resolved
AaronRobinsonMSFT
added a commit
to AaronRobinsonMSFT/zlib
that referenced
this pull request
Mar 19, 2021
During some CA work in the dotnet runtime project we discovered the VC++ code analysis has trouble determining the follow value is properly initialized prior to use. Instead of adding a suppression it seemed easier to simply initialize it. See dotnet/runtime#49194 (comment) for context.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42767
/cc @GrabYourPitchforks