Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use hosted pools to send libraries tests to helix to ease out our build pools #49497

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Use hosted pools to send libraries tests to helix to ease out our build pools #49497

merged 1 commit into from
Mar 11, 2021

Conversation

safern
Copy link
Member

@safern safern commented Mar 11, 2021

No description provided.

@ghost
Copy link

ghost commented Mar 11, 2021

Tagging subscribers to this area: @safern, @ViktorHofer, @Anipik
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: safern
Assignees: -
Labels:

area-Infrastructure-libraries
Milestone: -

@safern safern marked this pull request as ready for review March 11, 2021 20:59
@safern safern requested a review from a team March 11, 2021 20:59
hoyosjs
hoyosjs reviewed Mar 11, 2021
View reviewed changes
eng/pipelines/libraries/run-test-job.yml
pool:
vmImage: 'ubuntu-latest'

${{ if not(startsWith(parameters.pool.queue, 'BuildPool.Ubuntu')) }}:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to not do the same with non-Ubuntu pools? Seems a waste. Also how much of the build does this job download? We were hitting the 10gb+ limit on the publishing job, just want to make sure we are not getting close to that when doing this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MacOS already use hosted pools. I decided not to move windows to hosted pools to be careful about hitting the 200 parallel jobs on hosted pools across the org. We don't have as many windows legs as we do ubuntu pool based legs, so that's why I kept windows out. My first commit did include Windows, but I removed it after thinking about that.

Let me know if you think otherwise and we can include Windows here.

hoyosjs
hoyosjs approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@hoyosjs hoyosjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind as much. Mostly a question to know if there was a reason. If you think we are good on storage this lgtm given that this is mostly in response to resource constraints.

@safern safern merged commit 2796d17 into dotnet:main Mar 11, 2021
@safern safern deleted the SendHelixHosted branch March 11, 2021 22:14
@runfoapp runfoapp bot mentioned this pull request Mar 22, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Apr 10, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MattGal MattGal MattGal approved these changes

@hoyosjs hoyosjs hoyosjs approved these changes

Assignees
No one assigned
Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@safern @MattGal @hoyosjs @karelz