Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileStreamStrategies refactor #49750

Merged
merged 10 commits into from
Mar 18, 2021
Merged

FileStreamStrategies refactor #49750

merged 10 commits into from
Mar 18, 2021

Commits on Mar 17, 2021

  1. move all strategy-related types to Strategies subfolder and namespace

    @adamsitnik
    adamsitnik committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    2b046e7 View commit details
    Browse the repository at this point in the history

  2. make FileStreamHelpers a partial class, move some cross platform help… 

    …er methods there
    @adamsitnik
    adamsitnik committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    9297597 View commit details
    Browse the repository at this point in the history

  3. apply suggestions from David

    @adamsitnik
    adamsitnik committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    da4fd82 View commit details
    Browse the repository at this point in the history

  4. fix the Unix build?

    @adamsitnik
    adamsitnik committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    15bcf97 View commit details
    Browse the repository at this point in the history

  5. rename config switch

    @adamsitnik
    adamsitnik committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    3e95f03 View commit details
    Browse the repository at this point in the history

  6. strategy can't be null here, as FileStream has no finalizer now

    @adamsitnik
    adamsitnik committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    63ff936 View commit details
    Browse the repository at this point in the history

  7. it's enough to assert the buffer size in ctor, add message with an ex… 

    …planation
    @adamsitnik
    adamsitnik committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    482c1f6 View commit details
    Browse the repository at this point in the history

  8. fix formatting of the if blocks

    @adamsitnik
    adamsitnik committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    fdabd31 View commit details
    Browse the repository at this point in the history

  9. introduce ThrowArgumentException_HandleNotSync and reuse it

    @adamsitnik
    adamsitnik committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    16b275c View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2021

  1. address code review feedback

    @adamsitnik
    adamsitnik committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    6cf4ed3 View commit details
    Browse the repository at this point in the history