[wasm] Revert commit to fix library AOT tests #49784
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et#49072)" This reverts commit 686f752. Reverting this for now, as a workaround to get the AOT library tests working again. Running library tests with AOT+EnableAggressiveTrimming broke with: ``` info: Arguments: --run,WasmTestRunner.dll,System.Buffers.Tests.dll,-notrait,category=OuterLoop,-notrait,category=failing info: Initializing..... fail: System.AggregateException: AggregateException_ctor_DefaultMessage (Arg_NullReferenceException) ---> System.NullReferenceException: Arg_NullReferenceException at Xunit.Sdk.ReflectionAttributeInfo.GetNamedArgument[Int32](String argumentName) --- End of stack trace from previous location --- at Xunit.Sdk.ReflectionAttributeInfo.GetNamedArgument[Int32](String argumentName) --- End of stack trace from previous location --- at Xunit.Sdk.ReflectionAttributeInfo.GetNamedArgument[Int32](String argumentName) Exception_EndOfInnerExceptionStack info: Discovering: System.Buffers.Tests.dll (method display = ClassAndMethod, method display options = None) info: WASM EXIT 1 fail: Application has finished with exit code TESTS_FAILED but 0 was expected ``` More info: dotnet#49770
|
Tagging subscribers to this area: @BrzVlad Issue DetailsRevert "[interp] Rework the allocation of offsets for variables (#49072… This reverts commit 686f752. Reverting this for now, as a workaround to get the AOT library tests Running library tests with AOT+EnableAggressiveTrimming broke with: More info: #49770
|
|
/cc @lewing @steveisok |
This will allow the System.Buffers.Tests to run with AOT on CI authored by: @mdh1418
vargaz
approved these changes
Mar 17, 2021
|
closing in favor of #49789 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "[interp] Rework the allocation of offsets for variables (#49072…
…72)"
This reverts commit 686f752.
Reverting this for now, as a workaround to get the AOT library tests
working again.
Running library tests with AOT+EnableAggressiveTrimming broke with:
More info: #49770