Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary delegate/closure allocations from PollForValues #50357

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

stephentoub
Copy link
Member

It allocates a delegate/closure for each counter group each time the loop runs.

cc: @sywhang

It allocates a delegate/closure for each counter group each time the loop runs.
@ghost
Copy link

ghost commented Mar 29, 2021

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

Issue Details

It allocates a delegate/closure for each counter group each time the loop runs.

cc: @sywhang

Author: stephentoub
Assignees: -
Labels:

area-System.Diagnostics.Tracing

Milestone: 6.0.0

Copy link
Contributor

@sywhang sywhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @stephentoub

@stephentoub stephentoub merged commit 3870c9f into dotnet:main Mar 29, 2021
@stephentoub stephentoub deleted the pollforvalues branch March 29, 2021 18:52
@ghost ghost locked as resolved and limited conversation to collaborators Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants