Avoid race condition in EventSource_ConnectionPoolAtMaxConnections_LogsRequestLeftQueue #52887
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#50226 added asserts around
ActivityId
s of events.It is expecting that IDs of Start/Stop pairs match, relying on the order of events being the same.
The scenario is such that there are 2 requests pending from the client:
The server sends the response to the first request and then processes the second request as fast as possible.
The first request will receive its response and release the second request.
It is at this point that there is a race where the second request could finish and log
RequestStop
before the first request does.While this is perfectly fine correctness-wise, the test will fail as it's relying on the order of Starts being the same as that of Stops.
This PR waits before processing the second request until it confirms the first request has finished.
Fixes #52530