From f1b87665f577297dfa000a3e41db380b7ef140ce Mon Sep 17 00:00:00 2001 From: Mitchell Hwang Date: Tue, 18 May 2021 15:24:35 -0400 Subject: [PATCH 01/16] [mobile][libraries] Skip test suites failing on CI --- src/libraries/tests.proj | 21 ++++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index f4dc9a06872a9..935ee0bccbbf2 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -118,6 +118,14 @@ + + + + + + + + @@ -159,13 +167,18 @@ + + + + + + + + - - - @@ -177,11 +190,13 @@ + + From 02821807764bdd0e7d0460ee8610207f644367da Mon Sep 17 00:00:00 2001 From: Mitchell Hwang Date: Wed, 19 May 2021 11:37:57 -0400 Subject: [PATCH 02/16] [libraries] Add more flakey test suite crashes --- src/libraries/tests.proj | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index 935ee0bccbbf2..4b7daf73f8c75 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -119,18 +119,26 @@ - - + - + + - + + + + + + + + + @@ -196,9 +204,12 @@ - + + + + From 648c98614129fd453409f85b2d080a5ca996a3d5 Mon Sep 17 00:00:00 2001 From: Mitchell Hwang Date: Wed, 19 May 2021 11:38:23 -0400 Subject: [PATCH 03/16] [Android][libraries] Add DynamicChainTests.MismatchKeyIdentifiers failure --- .../tests/DynamicChainTests.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libraries/System.Security.Cryptography.X509Certificates/tests/DynamicChainTests.cs b/src/libraries/System.Security.Cryptography.X509Certificates/tests/DynamicChainTests.cs index 2fe04218e09d0..068a250afd580 100644 --- a/src/libraries/System.Security.Cryptography.X509Certificates/tests/DynamicChainTests.cs +++ b/src/libraries/System.Security.Cryptography.X509Certificates/tests/DynamicChainTests.cs @@ -592,6 +592,7 @@ public static void NameConstraintViolation_InvalidGeneralNames() } [Fact] + [ActiveIssue("", TestPlatforms.Android)] public static void MismatchKeyIdentifiers() { X509Extension[] intermediateExtensions = new [] From 170819228eb22bed98de46814dd9e51217692d64 Mon Sep 17 00:00:00 2001 From: Mitchell Hwang Date: Wed, 19 May 2021 11:55:32 -0400 Subject: [PATCH 04/16] Add issue to DynamicChainTests ActiveIssue --- .../tests/DynamicChainTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Security.Cryptography.X509Certificates/tests/DynamicChainTests.cs b/src/libraries/System.Security.Cryptography.X509Certificates/tests/DynamicChainTests.cs index 068a250afd580..dfe6149a08a75 100644 --- a/src/libraries/System.Security.Cryptography.X509Certificates/tests/DynamicChainTests.cs +++ b/src/libraries/System.Security.Cryptography.X509Certificates/tests/DynamicChainTests.cs @@ -592,7 +592,7 @@ public static void NameConstraintViolation_InvalidGeneralNames() } [Fact] - [ActiveIssue("", TestPlatforms.Android)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/52976", TestPlatforms.Android)] public static void MismatchKeyIdentifiers() { X509Extension[] intermediateExtensions = new [] From 7956258bfa8b9769a6338032a895d3e7ea5307b0 Mon Sep 17 00:00:00 2001 From: Mitchell Hwang Date: Wed, 19 May 2021 16:00:37 -0400 Subject: [PATCH 05/16] [Android] Add more flakey test suite crashes for Android arm64 --- src/libraries/tests.proj | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index 4b7daf73f8c75..0a62aa74813fc 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -124,13 +124,21 @@ + + + + + + + + From c8e403d9f2d1fbb9693ba2dc387e4b5d362fc00d Mon Sep 17 00:00:00 2001 From: Mitchell Hwang Date: Wed, 19 May 2021 16:38:27 -0400 Subject: [PATCH 06/16] [libraries] Add RunDisabledAndroidTests condition to be able to run tests on build lane --- src/libraries/tests.proj | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index 0a62aa74813fc..3323af7cf9b3c 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -108,7 +108,7 @@ - + @@ -141,7 +141,7 @@ - + @@ -149,7 +149,7 @@ - + From e35124bc3b7ee2544b9bbac5f175686457c08066 Mon Sep 17 00:00:00 2001 From: Mitchell Hwang Date: Wed, 19 May 2021 20:00:03 -0400 Subject: [PATCH 07/16] [Android] Add even more flakey test suites that crash --- src/libraries/tests.proj | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index 3323af7cf9b3c..63c1557d53212 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -123,6 +123,7 @@ + @@ -134,11 +135,13 @@ + + From 48af416be38731eda22d6385138f20edf9fb10f4 Mon Sep 17 00:00:00 2001 From: Mitchell Hwang Date: Thu, 20 May 2021 10:06:25 -0400 Subject: [PATCH 08/16] [iOS] Add System.Net.Security.Tests X509 Certificate not supported skips --- .../tests/FunctionalTests/SslStreamStreamToStreamTest.cs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamStreamToStreamTest.cs b/src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamStreamToStreamTest.cs index f7ca5892fc052..3ecfbc4e92493 100644 --- a/src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamStreamToStreamTest.cs +++ b/src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamStreamToStreamTest.cs @@ -68,6 +68,7 @@ public static IEnumerable SslStream_StreamToStream_Authentication_Succ [Theory] [MemberData(nameof(SslStream_StreamToStream_Authentication_Success_MemberData))] + [SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "X509 certificate store is not supported on iOS or tvOS.")] public async Task SslStream_StreamToStream_Authentication_Success(X509Certificate serverCert = null, X509Certificate clientCert = null) { (Stream stream1, Stream stream2) = TestHelper.GetConnectedStreams(); @@ -126,6 +127,7 @@ await TestConfiguration.WhenAllOrAnyFailedWithTimeout(client.AuthenticateAsClien } [Fact] + [SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "X509 certificate store is not supported on iOS or tvOS.")] public async Task Read_CorrectlyUnlocksAfterFailure() { (Stream stream1, Stream stream2) = TestHelper.GetConnectedStreams(); @@ -153,6 +155,7 @@ public async Task Read_CorrectlyUnlocksAfterFailure() } [Fact] + [SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "X509 certificate store is not supported on iOS or tvOS.")] public async Task Write_CorrectlyUnlocksAfterFailure() { (Stream stream1, Stream stream2) = TestHelper.GetConnectedStreams(); @@ -201,6 +204,7 @@ public async Task Read_InvokedSynchronously() } [Fact] + [SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "X509 certificate store is not supported on iOS or tvOS.")] public async Task Write_InvokedSynchronously() { (Stream stream1, Stream stream2) = TestHelper.GetConnectedStreams(); From 92b358be7deb6788371c5c816faafa886d3ba79a Mon Sep 17 00:00:00 2001 From: Mitchell Hwang Date: Thu, 20 May 2021 10:07:02 -0400 Subject: [PATCH 09/16] [libraries][Android] Add another round of test suite flakes for Android arm64 --- src/libraries/tests.proj | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index 63c1557d53212..d102e747c5c26 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -122,7 +122,10 @@ + + + @@ -131,6 +134,7 @@ + @@ -139,9 +143,15 @@ + + + + + + From e32d7e2f5698110e1bde9c59a648c8be38739d4c Mon Sep 17 00:00:00 2001 From: Mitchell Hwang Date: Thu, 20 May 2021 11:26:50 -0400 Subject: [PATCH 10/16] Remove suites that had Package Installation Error failures --- src/libraries/tests.proj | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index d102e747c5c26..c057b024aee4e 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -122,19 +122,19 @@ - + - + - + @@ -143,14 +143,14 @@ - + - - - - - + + + + + From 4e76d5d1fbd78fdd0bf3f87e22b5f644a36b006b Mon Sep 17 00:00:00 2001 From: Mitchell Hwang Date: Thu, 20 May 2021 13:21:33 -0400 Subject: [PATCH 11/16] [Android][libraries] Add more process crashed test suites --- src/libraries/tests.proj | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index c057b024aee4e..54779aed27b20 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -128,10 +128,13 @@ + + + From 9438e99548924ff1abad692923e4c4a944286bc0 Mon Sep 17 00:00:00 2001 From: Mitchell Hwang Date: Fri, 21 May 2021 09:31:17 -0400 Subject: [PATCH 12/16] Add more process crashed for Android arm and arm64 --- src/libraries/tests.proj | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index 54779aed27b20..1ed3a8ee7c6d1 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -106,6 +106,9 @@ + + + @@ -135,6 +138,7 @@ + @@ -203,7 +207,6 @@ - From 92cba9cc3b0c291d3bfe4e4eeb9b5f0e0c193c2c Mon Sep 17 00:00:00 2001 From: Mitchell Hwang Date: Fri, 21 May 2021 09:31:56 -0400 Subject: [PATCH 13/16] Remove test suites that failed due to Package Installation Failure --- src/libraries/tests.proj | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index 1ed3a8ee7c6d1..5308bbd8ccf6e 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -125,15 +125,12 @@ - - - @@ -141,7 +138,6 @@ - @@ -150,14 +146,8 @@ - - - - - - From f3e95da67ab94fb34257506c5daa2fd2ca8c51d5 Mon Sep 17 00:00:00 2001 From: Mitchell Hwang Date: Fri, 21 May 2021 12:26:52 -0400 Subject: [PATCH 14/16] [Android][libraries] Add System.Diagnostics.Process.Tests active issue --- src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs b/src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs index 71edaaa3c4067..47c538af8077f 100644 --- a/src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs +++ b/src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs @@ -2096,6 +2096,7 @@ public void TestLongProcessIsWorking() [ActiveIssue("https://github.com/dotnet/runtime/issues/29330", TestPlatforms.OSX)] [Fact] [ActiveIssue("https://github.com/dotnet/runtime/issues/52852", TestPlatforms.MacCatalyst)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/53095", TestPlatforms.Android)] public void LongProcessNamesAreSupported() { string sleepPath; From aaa2bade329400c68cc540d0ea1c5d8420dab9de Mon Sep 17 00:00:00 2001 From: Mitchell Hwang Date: Fri, 21 May 2021 12:27:14 -0400 Subject: [PATCH 15/16] [Android] Add more flakey test suite crashing from json error --- src/libraries/tests.proj | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index bd1a357c53a06..533fc60a1b73e 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -148,6 +148,9 @@ + + + From 04ce84780c2ac5a56e5f43844e6ac45aa1e31e70 Mon Sep 17 00:00:00 2001 From: Mitchell Hwang Date: Fri, 21 May 2021 12:32:39 -0400 Subject: [PATCH 16/16] [Android][libraries] JSON parsing exception section for suite skips --- src/libraries/tests.proj | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index 533fc60a1b73e..e62cabe7ba503 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -132,26 +132,27 @@ - - - - - + + + + + + + -