Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve morphing of comparisons #54204

Merged
merged 7 commits into from
Sep 16, 2021
Merged

Improve morphing of comparisons #54204

merged 7 commits into from
Sep 16, 2021

Commits on Sep 5, 2021

  1. Add SetIntegralValue helper to GenTreeIntCommon

    @SingleAccretion
    SingleAccretion committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    5dd6cf6 View commit details
    Browse the repository at this point in the history

  2. Fix a potential CSE issue

    @SingleAccretion
    SingleAccretion committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    c8e3b47 View commit details
    Browse the repository at this point in the history

  3. Enable comparisons against GT_CNS_LNG

    @SingleAccretion
    SingleAccretion committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    7fed31f View commit details
    Browse the repository at this point in the history

  4. Optimize unsigned compares with int/long.MaxValue 

    Replace LE_UN/GT_UN(OP, int/long.MaxValue) with GE/LT(OP, 0)
as that generates smaller code on all targets.
    @SingleAccretion
    SingleAccretion committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    315217f View commit details
    Browse the repository at this point in the history

  5. Relocate fgOptimizeRelationalComparisonWithConst 

    So that it is next to fgOptimizeEqualityComparisonWithConst.

Purely cosmetic change.
    @SingleAccretion
    SingleAccretion committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    386501b View commit details
    Browse the repository at this point in the history

  6. Use the fgUpdateConstTreeValueNumber helper

    @SingleAccretion
    SingleAccretion committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    b965c78 View commit details
    Browse the repository at this point in the history

  7. Fix formatting...

    @SingleAccretion
    SingleAccretion committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    ea26755 View commit details
    Browse the repository at this point in the history