Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][http] Improve compatibility of abort and cancelation of BrowserHttpHandler #55084

Merged
merged 3 commits into from
Jul 13, 2021

Conversation

pavelsavara
Copy link
Member

Fixes #54270

@pavelsavara pavelsavara marked this pull request as ready for review July 2, 2021 15:06
@pavelsavara pavelsavara added the arch-wasm WebAssembly architecture label Jul 2, 2021
@ghost
Copy link

ghost commented Jul 2, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #54270

Author: pavelsavara
Assignees: -
Labels:

area-System.Net.Http

Milestone: -

Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm not a browser handler expert though.

… expectations

added [ActiveIssue("dotnet#55083", TestPlatforms.Browser)] for redirect outerloop tests
@pavelsavara pavelsavara force-pushed the wasm_http_TaskCanceledException branch from b17546d to 139ca9c Compare July 12, 2021 11:20
@marek-safar
Copy link
Contributor

Is this ready for merge?

@lewing
Copy link
Member

lewing commented Jul 13, 2021

Failing test in runtime (Libraries Test Run release mono Linux x64 Debug) is

 Starting:    System.Threading.Tests (parallel test collections = on, max threads = 2)
    System.Threading.Tests.ThreadLocalTests.RunThreadLocalTest8_Values_NegativeCases [SKIP]
      Condition(s) not met: "IsPreciseGcSupported"
    System.Threading.Tests.ThreadLocalTests.RunThreadLocalTest5_Dispose [FAIL]
      Assert.True() Failure
      Expected: True
      Actual:   False
      Stack Trace:
        /_/src/libraries/System.Threading/tests/ThreadLocalTests.cs(139,0): at System.Threading.Tests.ThreadLocalTests.RunThreadLocalTest5_Dispose()
        /_/src/mono/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs(370,0): at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

It isn't related to to a browser only change.

@lewing lewing merged commit dc2d0cc into dotnet:main Jul 13, 2021
@karelz karelz added this to the 6.0.0 milestone Jul 15, 2021
@pavelsavara pavelsavara deleted the wasm_http_TaskCanceledException branch July 29, 2021 08:45
@ghost ghost locked as resolved and limited conversation to collaborators Aug 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Net.Http
Projects
None yet
6 participants