Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Http2_MultipleConnectionsEnabled_ConnectionLimitNotReached_ConcurrentRequestsSuccessfullyHandled #55572

Merged
merged 2 commits into from
Jul 14, 2021
Merged

Enable Http2_MultipleConnectionsEnabled_ConnectionLimitNotReached_ConcurrentRequestsSuccessfullyHandled #55572

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a78c66e
Enable Http2_MultipleConnectionsEnabled_ConnectionLimitNotReached_Con…
alnikola Jul 13, 2021
7994395
Update SocketsHttpHandlerTest.cs
alnikola Jul 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2077,10 +2077,11 @@ public sealed class SocketsHttpHandlerTest_Http2 : HttpClientHandlerTest_Http2
{
public SocketsHttpHandlerTest_Http2(ITestOutputHelper output) : base(output) { }

[ConditionalFact(nameof(SupportsAlpn))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/41078")]
public async Task Http2_MultipleConnectionsEnabled_ConnectionLimitNotReached_ConcurrentRequestsSuccessfullyHandled()
[ConditionalTheory(nameof(SupportsAlpn))]
[MemberData(nameof(ManyIterations))]
public async Task Http2_MultipleConnectionsEnabled_ConnectionLimitNotReached_ConcurrentRequestsSuccessfullyHandled(int m)
{
Assert.True(m > -1);
const int MaxConcurrentStreams = 2;
using Http2LoopbackServer server = Http2LoopbackServer.CreateServer();
using SocketsHttpHandler handler = CreateHandler();
Expand Down Expand Up @@ -2211,6 +2212,14 @@ public async Task Http2_MultipleConnectionsEnabled_OpenAndCloseMultipleConnectio
}
}

public static IEnumerable<object[]> ManyIterations()
{
for (var i = 0; i < 1000; i++)
{
yield return new object[] {i};
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just for testing CI, right? You'll remove this and put it back to being a fact before merging?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's correct.


[ConditionalFact(nameof(SupportsAlpn))]
[OuterLoop("Incurs long delay")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/43877")]
Expand Down