Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EventSourceActivity #55575

Merged
merged 3 commits into from
Jul 13, 2021
Merged

Remove EventSourceActivity #55575

merged 3 commits into from
Jul 13, 2021

Conversation

hrrrrustic
Copy link
Contributor

close #53177

@ghost
Copy link

ghost commented Jul 13, 2021

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

Issue Details

close #53177

Author: hrrrrustic
Assignees: -
Labels:

area-System.Diagnostics.Tracing

Milestone: -

@stephentoub
Copy link
Member

This file is included in both System.Private.CoreLib.Shared.projitems and Microsoft.Diagnostics.Tracing.EventSource.Redist.csproj and will need to be removed from both. As is, I'd expect the build to fail.

@hrrrrustic
Copy link
Contributor Author

hrrrrustic commented Jul 13, 2021

Ah yes, checked for references only .cs files 😄

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@stephentoub stephentoub merged commit f82b730 into dotnet:main Jul 13, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EventSourceActivity doesn't seem to be used anywhere
2 participants