-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 1240010 #55743
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
@maryamariyan the logging generator tests are failing because they are expecting non-localized messages:
|
src/libraries/Microsoft.CSharp/src/MultilingualResources/Microsoft.CSharp.de.xlf
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Mainly reviewed the updated test file LoggerMessageGeneratorParserTests.cs and I believe the rest are boilerplate diff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We accept that these translations are correct and the test issues should now be addressed.
Hello @ericstj! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Localized components test completed successfully. Remaining failures are flaky Linq.Expressions and Networking tests, and a nuget restore failure. Merging so that Preview7 gets localization. |
No description provided.