Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement dynamic member access for collection converters correctly #55846

Merged
merged 1 commit into from
Jul 16, 2021
Merged

Reimplement dynamic member access for collection converters correctly #55846

merged 1 commit into from
Jul 16, 2021

Conversation

layomia
Copy link
Contributor

@layomia layomia commented Jul 16, 2021

Addresses feedback from #55566 (comment).

@ghost
Copy link

ghost commented Jul 16, 2021

Tagging subscribers to this area: @eiriktsarpalis, @layomia
See info in area-owners.md if you want to be subscribed.

Issue Details

Addresses feedback from #55566 (comment).

Author: layomia
Assignees: -
Labels:

area-System.Text.Json
Milestone: -

@layomia layomia requested a review from eerhardt July 16, 2021 17:39
@layomia layomia self-assigned this Jul 16, 2021
@layomia layomia added this to the 6.0.0 milestone Jul 16, 2021
@layomia layomia mentioned this pull request Jul 16, 2021
Merged
eerhardt
eerhardt approved these changes Jul 16, 2021
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the quick turnaround on this.

@layomia layomia merged commit 3a19983 into dotnet:main Jul 16, 2021
@layomia layomia deleted the CollectionsLinker branch July 16, 2021 23:15
@eerhardt eerhardt mentioned this pull request Jul 19, 2021
Closed
@ManickaP ManickaP mentioned this pull request Jul 20, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Aug 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eerhardt eerhardt eerhardt approved these changes

@eiriktsarpalis eiriktsarpalis Awaiting requested review from eiriktsarpalis

@jozkee jozkee Awaiting requested review from jozkee

@steveharter steveharter Awaiting requested review from steveharter

Assignees

@layomia layomia

Labels
area-System.Text.Json
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@layomia @eerhardt